refactor: address review threads 71-75: remove Hash+Eq bounds, rename ansi_prefixes to ls_colors, update doc comment, make lscolors optional under color feature

Co-authored-by: KSXGitHub <11488886+KSXGitHub@users.noreply.github.com>

Author: Copilot

Cargo.toml

@@ -50,8 +50,9 @@ required-features = ["cli"]
 
 [features]
 default = ["cli"]
+color = ["dep:lscolors"]
 json = ["serde/derive", "serde_json"]
-cli = ["clap/derive", "clap_complete", "clap-utilities", "json"]
+cli = ["color", "clap/derive", "clap_complete", "clap-utilities", "json"]
 cli-completions = ["cli"]
 
 [dependencies]
@@ -70,7 +71,7 @@ rayon = "1.10.0"
 rounded-div = "0.1.4"
 serde = { version = "1.0.228", optional = true }
 serde_json = { version = "1.0.149", optional = true }
-lscolors = { version = "0.21", features = ["nu-ansi-term"] }
+lscolors = { version = "0.21", features = ["nu-ansi-term"], optional = true }
 smart-default = "0.7.1"
 sysinfo = "0.38.2"
 terminal_size = "0.4.3"

src/ls_colors.rs

@@ -1,29 +1,44 @@
 use crate::visualizer::coloring::Color;
+#[cfg(feature = "color")]
 use lscolors::{self, Indicator};
 
 /// ANSI color prefix strings for terminal output, initialized from the `LS_COLORS` environment
 /// variable.
 #[derive(Debug, Clone)]
 pub struct LsColors {
+    #[cfg(feature = "color")]
     directory: String,
+    #[cfg(feature = "color")]
     normal: String,
+    #[cfg(feature = "color")]
     executable: String,
+    #[cfg(feature = "color")]
     symlink: String,
 }
 
 impl LsColors {
     /// Initialize by reading the current environment's `LS_COLORS`.
     pub fn from_env() -> Self {
-        Self::from_ls_colors_crate(&lscolors::LsColors::from_env().unwrap_or_default())
+        #[cfg(feature = "color")]
+        return Self::from_ls_colors_crate(&lscolors::LsColors::from_env().unwrap_or_default());
+        #[cfg(not(feature = "color"))]
+        LsColors {}
     }
 
     /// Parse an `LS_COLORS`-format string into an [`LsColors`].
     ///
     /// Unrecognized or invalid entries are silently ignored.
     pub fn from_ls_colors_string(input: &str) -> Self {
-        Self::from_ls_colors_crate(&lscolors::LsColors::from_string(input))
+        #[cfg(feature = "color")]
+        return Self::from_ls_colors_crate(&lscolors::LsColors::from_string(input));
+        #[cfg(not(feature = "color"))]
+        {
+            let _ = input;
+            LsColors {}
+        }
     }
 
+    #[cfg(feature = "color")]
     fn from_ls_colors_crate(ls_colors: &lscolors::LsColors) -> Self {
         let prefix_for = |indicator: Indicator| {
             ls_colors
@@ -41,11 +56,17 @@ impl LsColors {
 
     /// Return the ANSI prefix string for the given [`Color`] variant.
     pub(crate) fn prefix_str(&self, color: Color) -> &str {
-        match color {
+        #[cfg(feature = "color")]
+        return match color {
             Color::Directory => &self.directory,
             Color::Normal => &self.normal,
             Color::Executable => &self.executable,
             Color::Symlink => &self.symlink,
+        };
+        #[cfg(not(feature = "color"))]
+        {
+            let _ = color;
+            ""
         }
     }
 }

src/visualizer.rs

@@ -61,7 +61,7 @@ where
     pub bar_alignment: BarAlignment,
     /// Distribution and total number of characters/blocks can be placed in a line.
     pub column_width_distribution: ColumnWidthDistribution,
-    /// Mapping of names to colors for colorful output.
+    /// Optional coloring configuration for colorful output, mapping full node paths to colors.
     pub coloring: Option<&'a Coloring>,
 }
 

src/visualizer/coloring.rs

@@ -11,24 +11,24 @@ use zero_copy_pads::Width;
 /// Coloring configuration: ANSI prefix strings from the environment and a full-path-to-color map.
 #[derive(Debug)]
 pub struct Coloring {
-    ansi_prefixes: LsColors,
+    ls_colors: LsColors,
     map: HashMap<PathBuf, Color>,
 }
 
 impl Coloring {
-    /// Create a new [`Coloring`] from ANSI prefixes and a full-path-to-color map.
-    pub fn new(ansi_prefixes: LsColors, map: HashMap<PathBuf, Color>) -> Self {
-        Coloring { ansi_prefixes, map }
+    /// Create a new [`Coloring`] from LS_COLORS prefixes and a full-path-to-color map.
+    pub fn new(ls_colors: LsColors, map: HashMap<PathBuf, Color>) -> Self {
+        Coloring { ls_colors, map }
     }
 
-    /// Return `(color, prefixes)` for a node, used to build a colored slice for rendering.
+    /// Return `(color, ls_colors)` for a node, used to build a colored slice for rendering.
     pub(super) fn node_color(&self, path: &Path, has_children: bool) -> Option<(Color, &LsColors)> {
         let color = if has_children {
             Some(Color::Directory)
         } else {
             self.map.get(path).copied()
         }?;
-        Some((color, &self.ansi_prefixes))
+        Some((color, &self.ls_colors))
     }
 }
 

src/visualizer/display.rs

@@ -3,12 +3,11 @@ use crate::size;
 use std::{
     ffi::OsStr,
     fmt::{Display, Error, Formatter},
-    hash::Hash,
 };
 
 impl<'a, Name, Size> Display for Visualizer<'a, Name, Size>
 where
-    Name: Display + Hash + Eq + AsRef<OsStr>,
+    Name: Display + AsRef<OsStr>,
     Size: size::Size + Into<u64>,
 {
     /// Create the ASCII chart.

src/visualizer/methods.rs

@@ -14,12 +14,12 @@ use tree_table::*;
 
 use super::{coloring::ColoredTreeHorizontalSlice, ColumnWidthDistribution, Visualizer};
 use crate::size;
-use std::{cmp::min, ffi::OsStr, fmt::Display, hash::Hash, path::PathBuf};
+use std::{cmp::min, ffi::OsStr, fmt::Display, path::PathBuf};
 use zero_copy_pads::{align_left, align_right};
 
 impl<'a, Name, Size> Visualizer<'a, Name, Size>
 where
-    Name: Display + Hash + Eq + AsRef<OsStr>,
+    Name: Display + AsRef<OsStr>,
     Size: size::Size + Into<u64>,
 {
     /// Create ASCII rows that visualize the [tree](crate::data_tree::DataTree), such rows