perf: use LinkedList to store list of paths

Author: KSXGitHub

src/hardlink/link_path_list.rs

@@ -6,27 +6,26 @@ pub use reflection::Reflection;
 
 pub use Reflection as LinkPathListReflection;
 
-use std::path::PathBuf;
+use pipe_trait::Pipe;
+use std::{collections::LinkedList, path::PathBuf};
 
 /// List of different hardlinks to the same file.
 ///
 /// **Serialization and deserialization:** _(feature: `json`)_ `LinkPathList` does not implement
 /// `Serialize` and `Deserialize` traits directly, instead, it can be converted into/from a
 /// [`Reflection`] which implements these traits.
 #[derive(Debug, Clone, PartialEq, Eq, Hash)]
-pub struct LinkPathList(
-    Vec<PathBuf>, // TODO: benchmark against LinkedList<PathBuf>
-);
+pub struct LinkPathList(LinkedList<PathBuf>);
 
 impl LinkPathList {
     /// Create a list of a single path.
     pub(crate) fn single(path: PathBuf) -> Self {
-        LinkPathList(vec![path])
+        [path].pipe(LinkedList::from).pipe(LinkPathList)
     }
 
     /// Add a path to the list.
     pub(crate) fn add(&mut self, path: PathBuf) {
-        self.0.push(path)
+        self.0.push_back(path);
     }
 
     /// Get the number of paths inside the list.

src/hardlink/link_path_list/iter.rs

@@ -1,10 +1,10 @@
 use super::LinkPathList;
 use pipe_trait::Pipe;
-use std::{iter::FusedIterator, path::PathBuf, slice};
+use std::{collections::linked_list, iter::FusedIterator, path::PathBuf};
 
 /// [Iterator] over the paths inside a [`LinkPathList`].
 #[derive(Debug, Clone)]
-pub struct Iter<'a>(slice::Iter<'a, PathBuf>);
+pub struct Iter<'a>(linked_list::Iter<'a, PathBuf>);
 
 impl LinkPathList {
     /// Iterate over the paths inside the list.
@@ -26,16 +26,6 @@ impl<'a> Iterator for Iter<'a> {
         self.0.size_hint()
     }
 
-    #[inline]
-    fn count(self) -> usize {
-        self.0.count()
-    }
-
-    #[inline]
-    fn nth(&mut self, n: usize) -> Option<Self::Item> {
-        self.0.nth(n)
-    }
-
     #[inline]
     fn last(self) -> Option<Self::Item> {
         self.0.last()

src/hardlink/link_path_list/reflection.rs

@@ -1,7 +1,10 @@
 use super::LinkPathList;
 use derive_more::{From, Into, IntoIterator};
 use pipe_trait::Pipe;
-use std::{collections::HashSet, path::PathBuf};
+use std::{
+    collections::{HashSet, LinkedList},
+    path::PathBuf,
+};
 
 #[cfg(feature = "json")]
 use serde::{Deserialize, Serialize};
@@ -41,6 +44,10 @@ impl From<LinkPathList> for Reflection {
 
 impl From<Reflection> for LinkPathList {
     fn from(value: Reflection) -> Self {
-        value.0.into_iter().collect::<Vec<_>>().pipe(LinkPathList)
+        value
+            .0
+            .into_iter()
+            .collect::<LinkedList<_>>()
+            .pipe(LinkPathList)
     }
 }