Skip to content

Commit 5df11e2

Browse files
CopilotKSXGitHub
andcommitted
Address code review: pin base image, pin Python 3.12, use python3 -m pip, add --frozen-lockfile
Co-authored-by: KSXGitHub <11488886+KSXGitHub@users.noreply.github.com>
1 parent 959d7c6 commit 5df11e2

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

.devcontainer/devcontainer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "parallel-disk-usage",
3-
"image": "mcr.microsoft.com/devcontainers/base:ubuntu",
3+
"image": "mcr.microsoft.com/devcontainers/base:ubuntu-24.04",
44
"features": {
55
"ghcr.io/devcontainers/features/rust:1": {
66
"version": "none",
@@ -11,7 +11,7 @@
1111
"nodeGypDependencies": true
1212
},
1313
"ghcr.io/devcontainers/features/python:1": {
14-
"version": "latest",
14+
"version": "3.12",
1515
"installTools": true
1616
},
1717
"ghcr.io/devcontainers-contrib/features/shellcheck:1": {},

.devcontainer/post-create.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
set -euo pipefail
33

44
echo "Installing Python dependencies..." >&2
5-
pip install toml
5+
python3 -m pip install --user toml
66

77
echo "Installing pnpm and project Node dependencies..." >&2
88
npm install -g pnpm@7.33.7
9-
(cd ci/github-actions && pnpm install)
9+
(cd ci/github-actions && pnpm install --frozen-lockfile)
1010

1111
echo "Installing hyperfine from GitHub release..." >&2
1212
hyperfine_version="1.20.0"

0 commit comments

Comments
 (0)