Skip to content

Commit 248ef19

Browse files
committed
docs(contributing): apply review feedback on scopes and test fixtures
1 parent 0bf26f7 commit 248ef19

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ type(scope): lowercase description
1313
### Rules
1414

1515
- **Types:** `feat`, `fix`, `refactor`, `perf`, `docs`, `style`, `chore`, `ci`, `test`, `lint`.
16-
- **Scopes** (optional): `cli`, `api`, `deps`, `readme`, `benchmark`, `toolchain`, `test`, or another relevant area.
16+
- **Scopes** (optional): `cli`, `api`, `deps`, `readme`, `benchmark`, `toolchain`, `test`, or other relevant areas.
1717
- **Description:** always lowercase after the colon, no trailing period, brief (3-7 words preferred).
1818
- **Breaking changes:** append `!` before the colon. For example: `feat(cli)!: remove deprecated flag`.
1919
- **Code identifiers** in descriptions should be wrapped in backticks. For example: `` chore(deps): update `rand` ``.
@@ -137,7 +137,7 @@ Use **descriptive names** for variables and closure parameters by default. Singl
137137
.fold(PathBuf::new(), |acc, x| acc.join(x))
138138
```
139139

140-
- **Test fixtures:** `let a`, `let b`, `let c` for interchangeable specimens with identical roles in equality or comparison tests, such as tests of commutativity. Do not use single letters when the variables have distinct roles; use `actual`/`expected` or similar descriptive names instead.
140+
- **Test fixtures:** `let a`, `let b`, `let c` for interchangeable specimens with identical roles in equality or comparison tests. Do not use single letters when the variables have distinct roles; use `actual`/`expected` or similar descriptive names instead.
141141

142142
```rust
143143
let a = vec![3, 1, 2].into_iter().collect::<BTreeSet<_>>();

0 commit comments

Comments
 (0)