Skip to content

Commit 334086a

Browse files
committed
Explicitly qualify new methods in GB_CHOLMOD
This should fix warnings on Julia 1.12.
1 parent 346e143 commit 334086a

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

src/solvers/cholmod.jl

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -74,15 +74,15 @@ function _extract_args(s, ::Type{T}) where {T<:CHOLMOD.VTypes}
7474
SuiteSparseGraphBLAS._copytoraw(unsafe_wrap(Array, Ptr{T}(s.x), (l + 1,), own = false))
7575
end
7676

77-
function GBVector{T}(D::CHOLMOD.Dense{T}) where {T}
77+
function SuiteSparseGraphBLAS.GBVector{T}(D::CHOLMOD.Dense{T}) where {T}
7878
@assert size(D, 2) == 1
7979
M = SuiteSparseGraphBLAS._sizedjlmalloc(length(D), T)
8080
copyto!(M, D)
8181
A = GBVector{T}(size(D, 1))
8282
SuiteSparseGraphBLAS.unsafepack!(A, D, false; order = ColMajor())
8383
return A
8484
end
85-
function GBVector{T}(S::CHOLMOD.Sparse{T}) where {T}
85+
function SuiteSparseGraphBLAS.GBVector{T}(S::CHOLMOD.Sparse{T}) where {T}
8686
@assert size(S, 2) == 1
8787
s = unsafe_load(pointer(S))
8888
if s.stype != 0
@@ -97,21 +97,21 @@ function GBVector{T}(S::CHOLMOD.Sparse{T}) where {T}
9797
return A
9898
end
9999

100-
GBVector{T}(D::Union{CHOLMOD.Sparse{T}, CHOLMOD.Dense{T}}) where {T} =
100+
SuiteSparseGraphBLAS.GBVector{T}(D::Union{CHOLMOD.Sparse{T}, CHOLMOD.Dense{T}}) where {T} =
101101
GBVector{T}(D)
102-
GBVector(D::Union{CHOLMOD.Sparse{T}, CHOLMOD.Dense{T}}) where {T} =
102+
SuiteSparseGraphBLAS.GBVector(D::Union{CHOLMOD.Sparse{T}, CHOLMOD.Dense{T}}) where {T} =
103103
GBVector{T}(D)
104104

105105
for Mat [:GBMatrix, :GBMatrixC, :GBMatrixR]
106106
@eval begin
107-
function $Mat{T}(D::CHOLMOD.Dense{T}) where {T}
107+
function SuiteSparseGraphBLAS.$Mat{T}(D::CHOLMOD.Dense{T}) where {T}
108108
M = SuiteSparseGraphBLAS._sizedjlmalloc(length(D), T)
109109
copyto!(M, D)
110110
A = $Mat{T}(size(D))
111111
SuiteSparseGraphBLAS.unsafepack!(A, D, false; order = ColMajor())
112112
return A
113113
end
114-
function $Mat{T}(S::CHOLMOD.Sparse{T}) where {T}
114+
function SuiteSparseGraphBLAS.$Mat{T}(S::CHOLMOD.Sparse{T}) where {T}
115115
s = unsafe_load(pointer(S))
116116
if s.stype != 0
117117
throw(ArgumentError("matrix has stype != 0. Convert to matrix " *
@@ -125,9 +125,9 @@ for Mat ∈ [:GBMatrix, :GBMatrixC, :GBMatrixR]
125125
return A
126126
end
127127

128-
$Mat{T}(D::Union{CHOLMOD.Sparse{T}, CHOLMOD.Dense{T}}) where {T} =
128+
SuiteSparseGraphBLAS.$Mat{T}(D::Union{CHOLMOD.Sparse{T}, CHOLMOD.Dense{T}}) where {T} =
129129
$Mat{T}(D)
130-
$Mat(D::Union{CHOLMOD.Sparse{T}, CHOLMOD.Dense{T}}) where {T} =
130+
SuiteSparseGraphBLAS.$Mat(D::Union{CHOLMOD.Sparse{T}, CHOLMOD.Dense{T}}) where {T} =
131131
$Mat{T}(D)
132132

133133
function LinearAlgebra.Symmetric{Float64,<:$Mat{Float64}}(S::Sparse{Float64})
@@ -146,16 +146,16 @@ for Mat ∈ [:GBMatrix, :GBMatrixC, :GBMatrixR]
146146
end
147147
convert(T::Type{Hermitian{Tv,<:$Mat{Tv}}}, A::Sparse{Tv}) where {Tv<:VTypes} = T(A)
148148

149-
function $Mat(FC::CHOLMOD.FactorComponent{Tv, :L}) where Tv
149+
function SuiteSparseGraphBLAS.$Mat(FC::CHOLMOD.FactorComponent{Tv, :L}) where Tv
150150
F = Factor(FC)
151151
s = unsafe_load(pointer(F))
152152
if s.is_ll == 0
153153
throw(CHOLMODException("sparse: supported only for :LD on LDLt factorizations"))
154154
end
155155
return $Mat(Sparse(F))
156156
end
157-
$Mat(FC::FactorComponent{Tv,:LD}) where {Tv} = $Mat(Sparse(Factor(FC)))
158-
function $Mat(F::Factor)
157+
SuiteSparseGraphBLAS.$Mat(FC::FactorComponent{Tv,:LD}) where {Tv} = $Mat(Sparse(Factor(FC)))
158+
function SuiteSparseGraphBLAS.$Mat(F::Factor)
159159
s = unsafe_load(pointer(F))
160160
if s.is_ll != 0
161161
L = Sparse(F)

0 commit comments

Comments
 (0)