Skip to content

Import two examples from the plotlyjs-julia website#523

Closed
mzaffalon wants to merge 3 commits intoJuliaPlots:masterfrom
mzaffalon:extra-examples
Closed

Import two examples from the plotlyjs-julia website#523
mzaffalon wants to merge 3 commits intoJuliaPlots:masterfrom
mzaffalon:extra-examples

Conversation

@mzaffalon
Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.72%. Comparing base (40caf9c) to head (a64bbc6).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #523       +/-   ##
===========================================
+ Coverage   28.67%   50.72%   +22.04%     
===========================================
  Files           8        8               
  Lines         265      276       +11     
===========================================
+ Hits           76      140       +64     
+ Misses        189      136       -53     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mzaffalon
Copy link
Copy Markdown
Contributor Author

mzaffalon commented Apr 17, 2026

The scattergl example in line-and-scatter.md generates a large SVG file.

@jd-foster
Copy link
Copy Markdown
Collaborator

jd-foster commented Apr 26, 2026

CI error is

┌ Error: Generated HTML over size_threshold limit: extra-examples/line-and-scatter.md
│     Generated file size: 1.08 (MiB)
│     size_threshold_warn: 400.0 (KiB)
│     size_threshold:      1.0 (MiB)
│     HTML file:           extra-examples/line-and-scatter/index.html
└ @ Documenter.HTMLWriter ~/.julia/packages/Documenter/AXNMp/src/html/HTMLWriter.jl:2000
┌ Warning: For 1 @example blocks, the 'text/html' representation of the resulting
│ object is above the threshold (example_size_threshold: 1048576 bytes).
│ - 1 blocks had 'image/svg+xml' fallback image representation available, using that.
│   On pages: extra-examples/line-and-scatter.md
└ @ Documenter.HTMLWriter ~/.julia/packages/Documenter/AXNMp/src/html/HTMLWriter.jl:915

We could definitely reduce size of the last example in line-and-scatter.md by changing the number of points from 100_000 to something much smaller (or just cut that example).

@jd-foster
Copy link
Copy Markdown
Collaborator

Now I look at the documentation repository, there is no licence provided, open-source or otherwise.

@mzaffalon mzaffalon closed this Apr 27, 2026
@mzaffalon mzaffalon deleted the extra-examples branch April 27, 2026 08:22
@mzaffalon
Copy link
Copy Markdown
Contributor Author

Instead of forcing the update of the remote branch I closed it. PR with the fix is now #524.

Regarding the licence: no licence means we cannot use the material without permission. Would you @jd-foster like to ask them?

@jd-foster
Copy link
Copy Markdown
Collaborator

Actually I see now that the website repo for hosting the plotly docs has a CC licence:
https://github.com/plotly/graphing-library-docs/blob/master/LICENSE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants