Aliasscope miss-compile for 1.11+#653
Merged
vchuravy merged 3 commits intorelease-0.9from Nov 3, 2025
Merged
Conversation
1146c2b to
653637b
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-0.9 #653 +/- ##
===============================================
+ Coverage 71.79% 71.85% +0.06%
===============================================
Files 14 14
Lines 904 906 +2
===============================================
+ Hits 649 651 +2
Misses 255 255 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
So the core of the issue is that I haven't been able to root-cause this for Julia itself. But since it occurs on the CPU backend this is likely a bug in either LLVM or Julia. I see two options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As observed in #652 these kernels behave differently on 1.11+
@giordano notes on Slack that this also resolves an issue he has observed with https://github.com/CliMA/Oceananigans.jl/blob/4265addd082f0462dfd4fc7114b89efa2a420ece/src/Models/NonhydrostaticModels/update_hydrostatic_pressure.jl#L12-L20