Fixes

Author: Katharine Hyatt

src/tensor/operations.jl

@@ -186,7 +186,7 @@ function plan_elementwise_binary(
     plan_pref = Ref{hiptensorPlanPreference_t}()
     hiptensorCreatePlanPreference(handle(), plan_pref, algo, jit)
 
-    plan = hipTensorPlan(desc[], plan_pref[]; workspacePref=workspace, compute_type = actual_compute_type)
+    plan = hipTensorPlan(desc[], plan_pref[]; workspacePref=workspace)
     hiptensorDestroyOperationDescriptor(desc[])
     hiptensorDestroyPlanPreference(plan_pref[])
     return plan
@@ -207,7 +207,6 @@ function permute!(
     else
         plan
     end
-    @show plan
     permute!(actual_plan, alpha, A, B)
 
     if plan === nothing
@@ -255,7 +254,7 @@ function plan_permutation(
     plan_pref = Ref{hiptensorPlanPreference_t}()
     hiptensorCreatePlanPreference(handle(), plan_pref, algo, jit)
 
-    plan = hipTensorPlan(desc[], plan_pref[]; workspacePref=workspace, compute_type = actual_compute_type)
+    plan = hipTensorPlan(desc[], plan_pref[]; workspacePref=workspace)
     hiptensorDestroyOperationDescriptor(desc[])
     hiptensorDestroyPlanPreference(plan_pref[])
     return plan
@@ -345,7 +344,7 @@ function plan_contraction(
     plan_pref = Ref{hiptensorPlanPreference_t}()
     hiptensorCreatePlanPreference(handle(), plan_pref, algo, jit)
 
-    plan = hipTensorPlan(desc[], plan_pref[]; workspacePref=workspace, compute_type = actual_compute_type)
+    plan = hipTensorPlan(desc[], plan_pref[]; workspacePref=workspace)
     hiptensorDestroyOperationDescriptor(desc[])
     hiptensorDestroyPlanPreference(plan_pref[])
     return plan

src/tensor/types.jl

@@ -38,6 +38,7 @@ const elementwise_trinary_compute_types = Dict(
 const elementwise_binary_compute_types = Dict(
     # typeA,     typeC       => typeCompute
     (Float16,    Float16)    => Float16,
+    (Float16,    Float32)    => Float32,
     (Float32,    Float32)    => Float32,
     (Float64,    Float64)    => Float64,
     (ComplexF32, ComplexF32) => Float32,

test/hiptensor/contractions.jl

@@ -91,8 +91,8 @@ eltypes = [(Float32, Float32, Float32, Float32),
         end
 
         @testset "simple case with plan storage and JIT compilation" begin
-            plan  = hipTENSOR.plan_contraction(dA, indsA, opA, dB, indsB, opB, dC, indsC, opC, opOut; jit=hipTENSOR.JIT_MODE_DEFAULT)
-            dC = hipTENSOR.contract!(plan, 1, dA, dB, 0, dC)
+            plan  = AMDGPU.hipTENSOR.plan_contraction(dA, indsA, opA, dB, indsB, opB, dC, indsC, opC, opOut; jit=hipTENSOR.JIT_MODE_DEFAULT)
+            dC = contract!(plan, 1, dA, dB, 0, dC)
             C = collect(dC)
             mC = reshape(permutedims(C, ipC), (loA, loB))
             @test mC ≈ mA * mB