Compute the arguments before the pytest.raises block

Four tests built an argument inside the block, so a failure there would have
been read as the call under test raising. The value is now prepared first,
leaving one call that can throw.

Author: JE-Chen

test/test_json_utils.py

@@ -45,5 +45,6 @@ def test_read_empty_file_returns_none(self, tmp_path):
     def test_read_invalid_json_raises(self, tmp_path):
         path = tmp_path / "bad.json"
         path.write_text("{invalid json", encoding="utf-8")
+        target = str(path)
         with pytest.raises(JEditorJsonException):
-            read_json(str(path))
+            read_json(target)

test/test_plugin_download.py

@@ -28,8 +28,9 @@ def test_a_plain_name_lands_in_the_directory(self, tmp_path):
 
     @pytest.mark.parametrize("name", ESCAPING_NAMES)
     def test_a_name_that_escapes_is_rejected(self, tmp_path, name):
+        directory = str(tmp_path)
         with pytest.raises(ValueError):
-            _safe_destination(str(tmp_path), name)
+            _safe_destination(directory, name)
 
 
 class TestDownloadingAPlugin:
@@ -47,8 +48,9 @@ def test_a_plain_name_is_written(self, tmp_path):
     def test_an_escaping_name_writes_nothing(self, tmp_path, name):
         destination = tmp_path / "plugins"
         destination.mkdir()
+        directory = str(destination)
         with pytest.raises(ValueError):
-            download_plugin_file("https://example.invalid/x.py", str(destination), name)
+            download_plugin_file("https://example.invalid/x.py", directory, name)
         assert list(tmp_path.rglob("*.py")) == []
 
 

test/test_text_codec.py

@@ -88,8 +88,9 @@ def test_undecodable_bytes_fall_back_instead_of_failing(self):
         assert isinstance(text, str) and encoding in {"utf-8", "latin-1"}
 
     def test_explicit_encoding_that_cannot_decode_raises(self):
+        encoded = "中文".encode("big5")
         with pytest.raises(UnicodeDecodeError):
-            decode_bytes("中文".encode("big5"), "ascii")
+            decode_bytes(encoded, "ascii")
 
     def test_bom_detection_without_a_bom(self):
         assert encoding_from_bom(b"plain") is None