feat(skills): add grid sizing, updating theming, PR template, agents#17185
feat(skills): add grid sizing, updating theming, PR template, agents#17185damyanpetev merged 10 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates internal contributor/agent documentation to centralize Ignite UI for Angular theming contribution guidance under .github/, and refreshes related skills and templates accordingly.
Changes:
- Added a new consolidated theming contribution guide at
.github/themes-contributing.md. - Updated agent docs to reference the new theming contribution guide.
- Tweaked skills/PR template guidance (Grid Lite docs URL pattern; added PR template checkboxes).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| skills/igniteui-angular-theming/SKILL.md | Removes the previous “Contributing” pointer section from the theming skill doc. |
| skills/igniteui-angular-grids/SKILL.md | Adds Grid Lite to the documented URL pattern list. |
| .github/themes-contributing.md | New, centralized reference for in-repo SCSS/theming contributions. |
| .github/agents/theming-styles-agent.md | Updates required reference path to the new theming contribution guide. |
| .github/agents/feature-orchestrator-agent.md | Updates theming guidance reference path to the new theming contribution guide. |
| .github/PULL_REQUEST_TEMPLATE.md | Adds additional “type” checkboxes (Tests/Changelog/Skills/Agents). |
| ### `null` Width | ||
|
|
||
| ```html | ||
| <igx-grid [width]="null" ...></igx-grid> | ||
| ``` |
There was a problem hiding this comment.
Well that's awkward as.. Had to do a double take and check with the docs since it makes no sense for unset width (null) in the DOM to ignore its layout context (say parent flex/grid) and I kind of don't think it could or should.
Honestly, this should be an addendum note for a edge use case where the goal is to disable virtualization, which is splits the grid out, not the first suggestion.
There was a problem hiding this comment.
Yeah, checks out really:
https://stackblitz.com/edit/rzvqtdcn?file=src%2Fapp%2Fgrid%2Fgrid-nested-data-binding-2%2Fgrid-nested-data-bind2.html
Just set width=null and display: flex on the container and you get a broken grid. Sizing is far from limited to width and I don't think we can easily ignore the rest.
There was a problem hiding this comment.
@copilot remove the sections related to null Width, because as Damyan points out, they do not provide correct information and null width usage should not be encouraged as an option.
There was a problem hiding this comment.
Addressed in fdf40cf. I moved the guidance to treat width=null as an edge-case addendum (virtualization-off behavior) instead of primary sizing guidance, and clarified that normal layout sizing from parent/container CSS is supported.
There was a problem hiding this comment.
Handled in fdf40cf. Added an explicit note that width=null can break expected responsive behavior in constrained/flex/grid containers because the grid expands to content width when virtualization is disabled.
Co-authored-by: Damyan Petev <damyanpetev@users.noreply.github.com>
Agent-Logs-Url: https://github.com/IgniteUI/igniteui-angular/sessions/4db7970d-eb66-4c96-a571-010d3be7c9ff Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>
Agent-Logs-Url: https://github.com/IgniteUI/igniteui-angular/sessions/f93e3aab-40e6-4d2c-97c0-4d3383a528c2 Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
damyanpetev
changed the title
Fixes IgniteUI/igniteui-cli#1608 for Angular
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)