fix(grid-state): avoid mutating sortingExpressions and filteringExpressionsTree in getState

Co-authored-by: ivanvpetrov <110455887+ivanvpetrov@users.noreply.github.com>
Agent-Logs-Url: https://github.com/IgniteUI/igniteui-angular/sessions/a49800a1-77b4-49ff-8685-0fc3b9034200

Author: Copilot

package-lock.json

@@ -139,10 +139,11 @@ export class IgxGridStateBaseDirective {
     private FEATURES = {
         sorting:  {
             getFeatureState: (context: IgxGridStateBaseDirective): IGridState => {
-                const sortingState = context.currGrid.sortingExpressions;
-                sortingState.forEach(s => {
-                    delete s.strategy;
-                    delete s.owner;
+                const sortingState = context.currGrid.sortingExpressions.map(s => {
+                    const copy: any = { ...s };
+                    delete copy.strategy;
+                    delete copy.owner;
+                    return copy;
                 });
                 return { sorting: sortingState };
             },
@@ -154,10 +155,14 @@ export class IgxGridStateBaseDirective {
             getFeatureState: (context: IgxGridStateBaseDirective): IGridState => {
                 const filteringState = context.currGrid.filteringExpressionsTree;
                 if (filteringState) {
-                    delete filteringState.owner;
-                    for (const item of filteringState.filteringOperands) {
-                        delete (item as IFilteringExpressionsTree).owner;
-                    }
+                    const filterCopy: any = { ...filteringState };
+                    delete filterCopy.owner;
+                    filterCopy.filteringOperands = filteringState.filteringOperands.map(item => {
+                        const itemCopy: any = { ...item };
+                        delete itemCopy.owner;
+                        return itemCopy;
+                    });
+                    return { filtering: filterCopy as IFilteringExpressionsTree };
                 }
                 return { filtering: filteringState };
             },
@@ -171,11 +176,14 @@ export class IgxGridStateBaseDirective {
                 const filteringState = context.currGrid.advancedFilteringExpressionsTree;
                 let advancedFiltering: any;
                 if (filteringState) {
-                    delete filteringState.owner;
-                    for (const item of filteringState.filteringOperands) {
-                        delete (item as IFilteringExpressionsTree).owner;
-                    }
-                    advancedFiltering = filteringState;
+                    const filterCopy: any = { ...filteringState };
+                    delete filterCopy.owner;
+                    filterCopy.filteringOperands = filteringState.filteringOperands.map(item => {
+                        const itemCopy: any = { ...item };
+                        delete itemCopy.owner;
+                        return itemCopy;
+                    });
+                    advancedFiltering = filterCopy;
                 } else {
                     advancedFiltering = {};
                 }

projects/igniteui-angular/grids/core/src/state-base.directive.ts

@@ -803,6 +803,47 @@ describe('IgxGridState - input properties #grid', () => {
         expect(prodIdColumn.colEnd).toBe(1);
     });
 
+    it('getState should not mutate sortingExpressions - strategy and owner should be preserved', () => {
+        const fix = TestBed.createComponent(IgxGridStateComponent);
+        fix.detectChanges();
+        const grid = fix.componentInstance.grid;
+        const state = fix.componentInstance.state;
+
+        const sortingStrategy = DefaultSortingStrategy.instance();
+        grid.sortingExpressions = [
+            { fieldName: 'ProductID', dir: SortingDirection.Asc, ignoreCase: false, strategy: sortingStrategy }
+        ];
+        fix.detectChanges();
+
+        state.getState(false, 'sorting');
+
+        expect(grid.sortingExpressions[0].strategy).toBe(sortingStrategy,
+            'strategy should not be deleted from the original sortingExpression after calling getState');
+    });
+
+    it('getState should not mutate filteringExpressionsTree - owner should be preserved', () => {
+        const fix = TestBed.createComponent(IgxGridStateComponent);
+        fix.detectChanges();
+        const grid = fix.componentInstance.grid;
+        const state = fix.componentInstance.state;
+
+        const gridFilteringExpressionsTree = new FilteringExpressionsTree(FilteringLogic.And);
+        const productFilteringExpressionsTree = new FilteringExpressionsTree(FilteringLogic.And, 'InStock');
+        const ownerRef = {};
+        (gridFilteringExpressionsTree as any).owner = ownerRef;
+        (productFilteringExpressionsTree as any).owner = ownerRef;
+        gridFilteringExpressionsTree.filteringOperands.push(productFilteringExpressionsTree);
+        grid.filteringExpressionsTree = gridFilteringExpressionsTree;
+        fix.detectChanges();
+
+        state.getState(false, 'filtering');
+
+        expect((grid.filteringExpressionsTree as any).owner).toBe(ownerRef,
+            'owner should not be deleted from the original filteringExpressionsTree after calling getState');
+        expect((grid.filteringExpressionsTree.filteringOperands[0] as any).owner).toBe(ownerRef,
+            'owner should not be deleted from the original filteringOperands after calling getState');
+    });
+
     it('should preserve column widths when restoring state with all columns hidden', () => {
         const fix = TestBed.createComponent(IgxGridStateComponent);
         fix.detectChanges();