|
| 1 | +package com.gooserelay.gooserelayvpn |
| 2 | + |
| 3 | +import com.google.common.truth.Truth.assertThat |
| 4 | +import com.gooserelay.gooserelayvpn.data.local.ProfileMigrations |
| 5 | +import org.json.JSONObject |
| 6 | +import org.junit.Test |
| 7 | +import java.io.File |
| 8 | +import java.sql.Connection |
| 9 | +import java.sql.DriverManager |
| 10 | + |
| 11 | +class ProfileMigrationsTest { |
| 12 | + |
| 13 | + private fun openMemoryDb(): Connection = |
| 14 | + DriverManager.getConnection("jdbc:sqlite::memory:") |
| 15 | + |
| 16 | + private fun existingColumns(conn: Connection): Set<String> { |
| 17 | + val columns = mutableSetOf<String>() |
| 18 | + conn.createStatement().use { st -> |
| 19 | + st.executeQuery("SELECT name FROM pragma_table_info('profiles')").use { rs -> |
| 20 | + while (rs.next()) columns.add(rs.getString(1)) |
| 21 | + } |
| 22 | + } |
| 23 | + return columns |
| 24 | + } |
| 25 | + |
| 26 | + private fun columnTypes(conn: Connection): Map<String, Pair<String, Int>> { |
| 27 | + val info = mutableMapOf<String, Pair<String, Int>>() |
| 28 | + conn.createStatement().use { st -> |
| 29 | + st.executeQuery("SELECT name, type, \"notnull\" FROM pragma_table_info('profiles')").use { rs -> |
| 30 | + while (rs.next()) info[rs.getString(1)] = rs.getString(2) to rs.getInt(3) |
| 31 | + } |
| 32 | + } |
| 33 | + return info |
| 34 | + } |
| 35 | + |
| 36 | + private fun exec(conn: Connection, sql: String) { |
| 37 | + conn.createStatement().use { it.execute(sql) } |
| 38 | + } |
| 39 | + |
| 40 | + @Test |
| 41 | + fun `registers exactly migrations 2 to 3 and 3 to 4`() { |
| 42 | + val ranges = ProfileMigrations.ALL.map { it.startVersion to it.endVersion } |
| 43 | + assertThat(ranges).containsExactly(2 to 3, 3 to 4).inOrder() |
| 44 | + } |
| 45 | + |
| 46 | + @Test |
| 47 | + fun `v2 table migrates to all 16 columns preserving data`() { |
| 48 | + val schemaJson = File("schemas/com.gooserelay.gooserelayvpn.data.local.AppDatabase/2.json") |
| 49 | + .readText() |
| 50 | + val createSql = JSONObject(schemaJson) |
| 51 | + .getJSONObject("database") |
| 52 | + .getJSONArray("entities") |
| 53 | + .getJSONObject(0) |
| 54 | + .getString("createSql") |
| 55 | + .replace("\${TABLE_NAME}", "profiles") |
| 56 | + |
| 57 | + openMemoryDb().use { conn -> |
| 58 | + exec(conn, createSql) |
| 59 | + exec( |
| 60 | + conn, |
| 61 | + "INSERT INTO profiles (name, debugTiming, socksHost, socksPort, googleHost, " + |
| 62 | + "sniJson, scriptKeysText, tunnelKey, isSelected, createdAt) " + |
| 63 | + "VALUES ('x', 0, '127.0.0.1', 1080, '216.239.38.120', '[]', '', 'k', 0, 1)" |
| 64 | + ) |
| 65 | + |
| 66 | + ProfileMigrations.migrationSql2To3(existingColumns(conn)).forEach { exec(conn, it) } |
| 67 | + ProfileMigrations.migrationSql3To4(existingColumns(conn)).forEach { exec(conn, it) } |
| 68 | + |
| 69 | + val info = columnTypes(conn) |
| 70 | + assertThat(info.keys).containsExactly( |
| 71 | + "id", "name", "debugTiming", "socksHost", "socksPort", "socksUser", "socksPass", |
| 72 | + "googleHost", "sniJson", "scriptKeysText", "tunnelKey", "coalesceStepMs", |
| 73 | + "idleSlotsPerBucket", "remoteUrl", "isSelected", "createdAt" |
| 74 | + ) |
| 75 | + assertThat(info["socksUser"]).isEqualTo("TEXT" to 1) |
| 76 | + assertThat(info["socksPass"]).isEqualTo("TEXT" to 1) |
| 77 | + assertThat(info["coalesceStepMs"]).isEqualTo("INTEGER" to 1) |
| 78 | + assertThat(info["idleSlotsPerBucket"]).isEqualTo("INTEGER" to 1) |
| 79 | + assertThat(info["remoteUrl"]).isEqualTo("TEXT" to 0) |
| 80 | + |
| 81 | + conn.createStatement().use { st -> |
| 82 | + st.executeQuery( |
| 83 | + "SELECT name, debugTiming, socksHost, socksPort, googleHost, " + |
| 84 | + "sniJson, scriptKeysText, tunnelKey, isSelected, createdAt FROM profiles" |
| 85 | + ).use { rs -> |
| 86 | + assertThat(rs.next()).isTrue() |
| 87 | + assertThat(rs.getString(1)).isEqualTo("x") |
| 88 | + assertThat(rs.getInt(2)).isEqualTo(0) |
| 89 | + assertThat(rs.getString(3)).isEqualTo("127.0.0.1") |
| 90 | + assertThat(rs.getInt(4)).isEqualTo(1080) |
| 91 | + assertThat(rs.getString(5)).isEqualTo("216.239.38.120") |
| 92 | + assertThat(rs.getString(6)).isEqualTo("[]") |
| 93 | + assertThat(rs.getString(7)).isEqualTo("") |
| 94 | + assertThat(rs.getString(8)).isEqualTo("k") |
| 95 | + assertThat(rs.getInt(9)).isEqualTo(0) |
| 96 | + assertThat(rs.getLong(10)).isEqualTo(1L) |
| 97 | + assertThat(rs.next()).isFalse() |
| 98 | + } |
| 99 | + } |
| 100 | + } |
| 101 | + } |
| 102 | + |
| 103 | + @Test |
| 104 | + fun `v3 fifteen column table migrates to v4 preserving data`() { |
| 105 | + openMemoryDb().use { conn -> |
| 106 | + exec( |
| 107 | + conn, |
| 108 | + "CREATE TABLE IF NOT EXISTS `profiles` (`id` INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, " + |
| 109 | + "`name` TEXT NOT NULL, `debugTiming` INTEGER NOT NULL, `socksHost` TEXT NOT NULL, " + |
| 110 | + "`socksPort` INTEGER NOT NULL, `socksUser` TEXT NOT NULL, `socksPass` TEXT NOT NULL, " + |
| 111 | + "`googleHost` TEXT NOT NULL, `sniJson` TEXT NOT NULL, `scriptKeysText` TEXT NOT NULL, " + |
| 112 | + "`tunnelKey` TEXT NOT NULL, `coalesceStepMs` INTEGER NOT NULL, " + |
| 113 | + "`idleSlotsPerBucket` INTEGER NOT NULL, `isSelected` INTEGER NOT NULL, " + |
| 114 | + "`createdAt` INTEGER NOT NULL)" |
| 115 | + ) |
| 116 | + exec( |
| 117 | + conn, |
| 118 | + "INSERT INTO profiles (name, debugTiming, socksHost, socksPort, socksUser, socksPass, " + |
| 119 | + "googleHost, sniJson, scriptKeysText, tunnelKey, coalesceStepMs, idleSlotsPerBucket, " + |
| 120 | + "isSelected, createdAt) " + |
| 121 | + "VALUES ('y', 1, '10.0.0.1', 1081, 'u', 'p', '216.239.38.120', '[]', 'sk', 'k2', 0, 2, 1, 2)" |
| 122 | + ) |
| 123 | + |
| 124 | + val before = existingColumns(conn) |
| 125 | + ProfileMigrations.migrationSql3To4(before).forEach { exec(conn, it) } |
| 126 | + |
| 127 | + val after = existingColumns(conn) |
| 128 | + assertThat(after - before).containsExactly("remoteUrl") |
| 129 | + assertThat(after).containsExactly( |
| 130 | + "id", "name", "debugTiming", "socksHost", "socksPort", "socksUser", "socksPass", |
| 131 | + "googleHost", "sniJson", "scriptKeysText", "tunnelKey", "coalesceStepMs", |
| 132 | + "idleSlotsPerBucket", "remoteUrl", "isSelected", "createdAt" |
| 133 | + ) |
| 134 | + |
| 135 | + conn.createStatement().use { st -> |
| 136 | + st.executeQuery( |
| 137 | + "SELECT name, socksUser, socksPass, tunnelKey, coalesceStepMs, " + |
| 138 | + "idleSlotsPerBucket FROM profiles" |
| 139 | + ).use { rs -> |
| 140 | + assertThat(rs.next()).isTrue() |
| 141 | + assertThat(rs.getString(1)).isEqualTo("y") |
| 142 | + assertThat(rs.getString(2)).isEqualTo("u") |
| 143 | + assertThat(rs.getString(3)).isEqualTo("p") |
| 144 | + assertThat(rs.getString(4)).isEqualTo("k2") |
| 145 | + assertThat(rs.getInt(5)).isEqualTo(0) |
| 146 | + assertThat(rs.getInt(6)).isEqualTo(2) |
| 147 | + assertThat(rs.next()).isFalse() |
| 148 | + } |
| 149 | + } |
| 150 | + } |
| 151 | + } |
| 152 | + |
| 153 | + @Test |
| 154 | + fun `v3 thirteen column table migrates without duplicating socksUser and socksPass`() { |
| 155 | + openMemoryDb().use { conn -> |
| 156 | + exec( |
| 157 | + conn, |
| 158 | + "CREATE TABLE IF NOT EXISTS `profiles` (`id` INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, " + |
| 159 | + "`name` TEXT NOT NULL, `debugTiming` INTEGER NOT NULL, `socksHost` TEXT NOT NULL, " + |
| 160 | + "`socksPort` INTEGER NOT NULL, `socksUser` TEXT NOT NULL, `socksPass` TEXT NOT NULL, " + |
| 161 | + "`googleHost` TEXT NOT NULL, `sniJson` TEXT NOT NULL, `scriptKeysText` TEXT NOT NULL, " + |
| 162 | + "`tunnelKey` TEXT NOT NULL, `isSelected` INTEGER NOT NULL, " + |
| 163 | + "`createdAt` INTEGER NOT NULL)" |
| 164 | + ) |
| 165 | + exec( |
| 166 | + conn, |
| 167 | + "INSERT INTO profiles (name, debugTiming, socksHost, socksPort, socksUser, socksPass, " + |
| 168 | + "googleHost, sniJson, scriptKeysText, tunnelKey, isSelected, createdAt) " + |
| 169 | + "VALUES ('z', 0, '127.0.0.1', 1080, 'u2', 'p2', '216.239.38.120', '[]', '', 'k3', 0, 3)" |
| 170 | + ) |
| 171 | + |
| 172 | + val before = existingColumns(conn) |
| 173 | + ProfileMigrations.migrationSql3To4(before).forEach { exec(conn, it) } |
| 174 | + |
| 175 | + val after = existingColumns(conn) |
| 176 | + assertThat(after - before).containsExactly( |
| 177 | + "coalesceStepMs", "idleSlotsPerBucket", "remoteUrl" |
| 178 | + ) |
| 179 | + assertThat(after.count { it == "socksUser" }).isEqualTo(1) |
| 180 | + assertThat(after.count { it == "socksPass" }).isEqualTo(1) |
| 181 | + |
| 182 | + conn.createStatement().use { st -> |
| 183 | + st.executeQuery("SELECT name, socksUser, socksPass, tunnelKey FROM profiles").use { rs -> |
| 184 | + assertThat(rs.next()).isTrue() |
| 185 | + assertThat(rs.getString(1)).isEqualTo("z") |
| 186 | + assertThat(rs.getString(2)).isEqualTo("u2") |
| 187 | + assertThat(rs.getString(3)).isEqualTo("p2") |
| 188 | + assertThat(rs.getString(4)).isEqualTo("k3") |
| 189 | + assertThat(rs.next()).isFalse() |
| 190 | + } |
| 191 | + } |
| 192 | + } |
| 193 | + } |
| 194 | + |
| 195 | + @Test |
| 196 | + fun `migrationSql3To4 is a no-op on the full v4 column set`() { |
| 197 | + val full16 = setOf( |
| 198 | + "id", "name", "debugTiming", "socksHost", "socksPort", "socksUser", "socksPass", |
| 199 | + "googleHost", "sniJson", "scriptKeysText", "tunnelKey", "coalesceStepMs", |
| 200 | + "idleSlotsPerBucket", "remoteUrl", "isSelected", "createdAt" |
| 201 | + ) |
| 202 | + assertThat(ProfileMigrations.migrationSql3To4(full16)).isEmpty() |
| 203 | + } |
| 204 | +} |
0 commit comments