fix: stripped time from meta date as datetime (#248)

This reverts commit ac3309a.

Author: Guts

mkdocs_rss_plugin/plugin.py

@@ -61,7 +61,7 @@ def __init__(self):
         self.src_date_created = self.src_date_updated = "git"
         self.meta_datetime_format: Optional[str] = None
         self.meta_default_timezone: str = "UTC"
-        self.meta_default_time: Optional[str] = None
+        self.meta_default_time: Optional[datetime.time] = None
         # pages storage
         self.pages_to_filter: list = []
         # prepare output feeds
@@ -160,6 +160,8 @@ def on_config(self, config: config_options.Config) -> dict:
                         f"'{self.meta_default_time}' format doesn't match the expected "
                         f"format %H:%M. Trace: {err}"
                     )
+            else:
+                self.meta_default_time = datetime.min
 
             if self.config.use_git:
                 logger.debug(

mkdocs_rss_plugin/util.py

@@ -168,7 +168,7 @@ def get_file_dates(
         source_date_update: str = "git",
         meta_datetime_format: str = "%Y-%m-%d %H:%M",
         meta_default_timezone: str = "UTC",
-        meta_default_time: datetime = None,
+        meta_default_time: Optional[datetime] = None,
     ) -> Tuple[datetime, datetime]:
         """Extract creation and update dates from page metadata (yaml frontmatter) or
         git log for given file.
@@ -193,6 +193,8 @@ def get_file_dates(
         """
         # empty vars
         dt_created = dt_updated = None
+        if meta_default_time is None:
+            meta_default_time = self.meta_default_time = datetime.min
 
         # if enabled, try to retrieve dates from page metadata
         if not self.use_git or (
@@ -416,14 +418,20 @@ def get_date_from_meta(
         try:
             if isinstance(date_metatag_value, str):
                 out_date = datetime.strptime(date_metatag_value, meta_datetime_format)
-            elif isinstance(date_metatag_value, (date, datetime)):
-                if isinstance(meta_default_time, datetime):
-                    time_to_add = meta_default_time.time()
-                else:
-                    time_to_add = datetime.min.time()
-                out_date = datetime.combine(date_metatag_value, time_to_add)
+            # datetime being a subclass of date, the following elif order matters
+            # see: https://stackoverflow.com/a/68743663/2556577
+            elif isinstance(date_metatag_value, datetime):
+                # if datetime, use it directly
+                out_date = date_metatag_value
+            elif isinstance(date_metatag_value, date):
+                out_date = datetime.combine(
+                    date=date_metatag_value, time=meta_default_time.time()
+                )
             else:
-                logger.debug(f"Incompatible date type: {type(date_metatag_value)}")
+                logger.info(
+                    f"Incompatible date type: {type(date_metatag_value)}. It must be: "
+                    "date, datetime or str (complying with defined strftime format)."
+                )
                 return out_date
         except ValueError as err:
             logger.error(