Fix hydrateMessages silently dropping user messages

Author: cstns

frontend/src/stores/product-expert.js

@@ -849,8 +849,11 @@ export const useProductExpertStore = defineStore('product-expert', {
         },
         hydrateMessages (messages) {
             if (!messages) return
-            const isAiMessage = (message) => message.answer && Array.isArray(message.answer)
-            const isUserMessage = (message) => Object.prototype.hasOwnProperty.call(message, 'query') && message.query
+            // both predicates must return real booleans: the switch(true)
+            // below matches with strict equality, so a truthy string (e.g.
+            // the query text) would silently never match
+            const isAiMessage = (message) => Boolean(message.answer && Array.isArray(message.answer))
+            const isUserMessage = (message) => Boolean(Object.prototype.hasOwnProperty.call(message, 'query') && message.query)
 
             messages.forEach((message) => {
                 switch (true) {

test/unit/frontend/stores/product-expert-hydrate.spec.js

@@ -0,0 +1,16 @@
+import { createPinia, setActivePinia } from 'pinia'
+import { describe, expect, test, vi } from 'vitest'
+
+vi.mock('@/composables/services/MqttExpertTopicHelper.ts', () => ({ default: {}, getEntityTopicPaths: () => ({}) }))
+
+import { ONBOARDING_FIXTURE_MESSAGES } from '../../../../frontend/src/components/expert/composables/onboardingFixture.js'
+import { useProductExpertStore } from '../../../../frontend/src/stores/product-expert.js'
+
+describe('hydrate fixture', () => {
+    test('hydrates ai and human messages', () => {
+        setActivePinia(createPinia())
+        const store = useProductExpertStore()
+        store.hydrateMessages(ONBOARDING_FIXTURE_MESSAGES)
+        expect(store.messages.map(m => m._type)).toEqual(['ai', 'human', 'ai', 'human', 'ai'])
+    })
+})