[8383] Stop the welcome tour firing on the AI onboarding path

The tour explains hosted instances, remote instances and the audit log to
someone who has just arrived and has none of them. On the onboarding path the
Expert covers the same ground by building something, so the tour talks over
it.

The education modal goes with it: it is not triggered independently, it opens
as the tour's completion callback.

The flag is never raised rather than raised and ignored. Onboarding sits
outside the team route tree, so nothing checks the flag while the user is in
the conversation, and leaving it set would fire the tour at them later when
they reached the team page.

Both remain reachable from the user menu, and both behave exactly as before
when AI onboarding is off. Adds the page's first spec covering all of it.

Author: cstns

frontend/src/pages/UnverifiedEmail.vue

@@ -34,6 +34,7 @@ import userApi from '../api/user.js'
 import FFLayoutBox from '../layouts/Box.vue'
 
 import { useAccountAuthStore } from '@/stores/account-auth.js'
+import { useAccountSettingsStore } from '@/stores/account-settings.js'
 import { useUxToursStore } from '@/stores/ux-tours.js'
 import { useUxStore } from '@/stores/ux.js'
 
@@ -51,7 +52,8 @@ export default {
         }
     },
     computed: {
-        ...mapState(useAccountAuthStore, ['user'])
+        ...mapState(useAccountAuthStore, ['user']),
+        ...mapState(useAccountSettingsStore, ['featuresCheck'])
     },
     methods: {
         ...mapActions(useUxStore, ['setNewlyCreatedUser']),
@@ -60,7 +62,9 @@ export default {
             try {
                 await userApi.verifyEmailToken(this.token)
                 clearTimeout(this.resendTimeout)
-                this.presentTour()
+                if (!this.featuresCheck?.isAiOnboardingFeatureEnabled) {
+                    this.presentTour()
+                }
                 this.setNewlyCreatedUser()
                 this.$router.go()
             } catch (err) {

test/unit/frontend/pages/UnverifiedEmail.spec.js

@@ -0,0 +1,97 @@
+import { flushPromises, mount } from '@vue/test-utils'
+import { beforeEach, describe, expect, test, vi } from 'vitest'
+
+const mocks = vi.hoisted(() => {
+    return {
+        authStore: { user: { username: 'alice' } },
+        settingsStore: { featuresCheck: {} },
+        toursStore: { presentTour: vi.fn() },
+        uxStore: { setNewlyCreatedUser: vi.fn() }
+    }
+})
+
+vi.mock('@/stores/account-auth.js', () => ({
+    useAccountAuthStore: () => mocks.authStore
+}))
+vi.mock('@/stores/account-settings.js', () => ({
+    useAccountSettingsStore: () => mocks.settingsStore
+}))
+vi.mock('@/stores/ux-tours.js', () => ({
+    useUxToursStore: () => mocks.toursStore
+}))
+vi.mock('@/stores/ux.js', () => ({
+    useUxStore: () => mocks.uxStore
+}))
+vi.mock('../../../../frontend/src/api/user.js', () => ({
+    default: {
+        verifyEmailToken: vi.fn().mockResolvedValue({}),
+        triggerVerification: vi.fn().mockResolvedValue({})
+    }
+}))
+vi.mock('../../../../frontend/src/layouts/Box.vue', () => ({
+    default: { name: 'FFLayoutBox', template: '<div><slot /><slot name="content" /></div>' }
+}))
+
+// imported after mocks so vi.mock hoisting resolves correctly
+import userApi from '../../../../frontend/src/api/user.js'
+import UnverifiedEmail from '../../../../frontend/src/pages/UnverifiedEmail.vue'
+
+const routerGo = vi.fn()
+
+function mountPage () {
+    return mount(UnverifiedEmail, {
+        global: {
+            stubs: { 'ff-button': true, 'ff-text-input': true },
+            mocks: { $router: { go: routerGo } }
+        }
+    })
+}
+
+describe('UnverifiedEmail', () => {
+    beforeEach(() => {
+        mocks.settingsStore.featuresCheck = {}
+        mocks.toursStore.presentTour.mockClear()
+        mocks.uxStore.setNewlyCreatedUser.mockClear()
+        userApi.verifyEmailToken.mockClear()
+        userApi.verifyEmailToken.mockResolvedValue({})
+        routerGo.mockClear()
+    })
+
+    async function verify (wrapper) {
+        wrapper.vm.token = 'a-token'
+        await wrapper.vm.submitVerificationToken()
+        await flushPromises()
+    }
+
+    test('queues the welcome tour on the classic path', async () => {
+        const wrapper = mountPage()
+        await verify(wrapper)
+        expect(mocks.toursStore.presentTour).toHaveBeenCalledTimes(1)
+    })
+
+    // The tour and the education modal it opens on close both explain concepts
+    // the onboarding conversation covers by doing
+    test('does not queue the welcome tour when AI onboarding is enabled', async () => {
+        mocks.settingsStore.featuresCheck = { isAiOnboardingFeatureEnabled: true }
+        const wrapper = mountPage()
+        await verify(wrapper)
+        expect(mocks.toursStore.presentTour).not.toHaveBeenCalled()
+    })
+
+    test('still marks the user as newly created either way', async () => {
+        mocks.settingsStore.featuresCheck = { isAiOnboardingFeatureEnabled: true }
+        const wrapper = mountPage()
+        await verify(wrapper)
+        expect(mocks.uxStore.setNewlyCreatedUser).toHaveBeenCalledTimes(1)
+        expect(routerGo).toHaveBeenCalledTimes(1)
+    })
+
+    test('queues nothing when verification fails', async () => {
+        userApi.verifyEmailToken.mockRejectedValue(new Error('nope'))
+        vi.spyOn(console, 'error').mockImplementation(() => {})
+        const wrapper = mountPage()
+        await verify(wrapper)
+        expect(mocks.toursStore.presentTour).not.toHaveBeenCalled()
+        expect(mocks.uxStore.setNewlyCreatedUser).not.toHaveBeenCalled()
+    })
+})