Skip to content

Commit c652130

Browse files
committed
Merge branch 'v1.x' into v2.x
2 parents 0190be4 + a1cb5c0 commit c652130

2 files changed

Lines changed: 17 additions & 0 deletions

File tree

FeastTests/HttpRequest/CurlTest.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,18 @@ public function testGetInvalidAsXml(): void
199199
);
200200
}
201201

202+
public function testGetResponseCode(): void
203+
{
204+
$request = new Curl();
205+
$request->get('https://www.google.com/json');
206+
$request->makeRequest();
207+
$response = $request->getResponse();
208+
$this->assertEquals(200, $response->getResponseCode());
209+
$this->assertNull(
210+
$request->getResponseAsXml()
211+
);
212+
}
213+
202214
public function testGetResultAsJson(): void
203215
{
204216
$request = new Curl();

HttpRequest/Response.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,9 @@ public function getResultAsXml(): ?SimpleXMLElement
5757
return null;
5858
}
5959
}
60+
61+
public function getResponseCode(): int
62+
{
63+
return $this->responseCode;
64+
}
6065
}

0 commit comments

Comments
 (0)