Renamed facades

Author: FlorianRappl

docs/SignalR-Implementation-Summary.md

@@ -41,7 +41,7 @@ Blazor Server applications where:
 - Implemented Socket.IO-compatible interface for API compatibility
 
 ### Phase 4: API Bridge Adaptation ✅
-- Created `SignalRFacade` implementing `IFacade` interface
+- Created `SignalRConnection` implementing `ISocketConnection` interface
 - Ensured existing Electron API classes work with SignalR
 - Implemented type conversion helper for SignalR's JSON deserialization
 - Event routing from both directions (.NET ↔ Electron)
@@ -60,8 +60,8 @@ Blazor Server applications where:
 
 ## Key Components
 
-### 1. SignalRFacade (`src/ElectronNET.AspNet/Bridge/SignalRFacade.cs`)
-- Implements `IFacade` interface to match Socket.IO facade API
+### 1. SignalRConnection (`src/ElectronNET.AspNet/Bridge/SignalRConnection.cs`)
+- Implements `ISocketConnection` interface to match Socket.IO facade API
 - Handles bidirectional event routing using `IHubContext<ElectronHub>`
 - Includes `ConvertToType<T>` helper for handling SignalR's JSON deserialization quirks
 - Critical fix: Handles `JsonElement` and numeric type conversions (long → int)
@@ -155,8 +155,8 @@ SignalR mode uses .NET-first startup (vs. Electron-first in Socket.IO mode) beca
 4. **Better for Blazor Server** - Blazor is already running when Electron starts
 5. **Single process debugging** - Developer debugs .NET process which owns Electron
 
-### Why IFacade Interface?
-Introducing `IFacade` allows `BridgeConnector.Socket` to return either `SocketIOFacade` or `SignalRFacade` based on startup mode, ensuring existing API code works with both transport mechanisms without modification.
+### Why ISocketConnection Interface?
+Introducing `ISocketConnection` allows `BridgeConnector.Socket` to return either `SocketIOConnection` or `SignalRConnection` based on startup mode, ensuring existing API code works with both transport mechanisms without modification.
 
 ### Why Keep-Alive Window?
 Electron quits immediately on macOS if no windows exist. The keep-alive window ensures Electron stays running during the connection and API initialization phase. It's automatically destroyed when the first real window is created.
@@ -208,7 +208,7 @@ Blazor Server already uses SignalR for component communication (`/_blazor` hub).
 ### 3. Type Conversion Failures
 **Problem**: SignalR deserializes JSON numbers as `JsonElement` or `long`, causing `Once<int>` handlers to fail silently.
 
-**Solution**: `SignalRFacade.ConvertToType<T>` handles JsonElement deserialization and numeric conversions.
+**Solution**: `SignalRConnection.ConvertToType<T>` handles JsonElement deserialization and numeric conversions.
 
 ### 4. Window Shutdown Not Triggering Exit
 **Problem**: Keep-alive window prevented `window-all-closed` event from firing.
@@ -391,7 +391,7 @@ Existing applications do not need to change. SignalR mode is opt-in via command-
 ## File Changes Summary
 
 **New Files**:
-- `src/ElectronNET.AspNet/Bridge/SignalRFacade.cs` (225 lines)
+- `src/ElectronNET.AspNet/Bridge/SignalRConnection.cs` (225 lines)
 - `src/ElectronNET.AspNet/Hubs/ElectronHub.cs` (108 lines)
 - `src/ElectronNET.AspNet/Runtime/Controllers/RuntimeControllerAspNetDotnetFirstSignalR.cs` (163 lines)
 - `src/ElectronNET.AspNet/Services/IElectronAuthenticationService.cs` (20 lines)

docs/SignalR-Startup-Mode.md

@@ -107,7 +107,7 @@ The application will:
 ### .NET Side
 
 - **`ElectronHub`** - SignalR hub at `/electron-hub`
-- **`SignalRFacade`** - Mimics `SocketIoFacade` interface for compatibility
+- **`SignalRConnection`** - Mimics `SocketIOConnection` interface for compatibility
 - **`RuntimeControllerAspNetDotnetFirstSignalR`** - Lifecycle management
 - **`StartupMethod.PackagedDotnetFirstSignalR`** - For packaged apps
 - **`StartupMethod.UnpackedDotnetFirstSignalR`** - For debugging
@@ -128,7 +128,7 @@ The application will:
 
 ## Current Limitations (Phase 6 Work Needed)
 
-⚠️ **Electron API Integration** - Existing Electron APIs (WindowManager, Dialog, etc.) still use SocketIoFacade. Full integration requires:
+⚠️ **Electron API Integration** - Existing Electron APIs (WindowManager, Dialog, etc.) still use SocketIOConnection. Full integration requires:
 - Refactoring APIs to work with both facades, or
 - Creating an adapter pattern
 
@@ -158,7 +158,7 @@ The application will:
 - URL parameter handling
 
 ### Phase 4: API Bridge ✅ (Basic Structure)
-- `SignalRFacade` class
+- `SignalRConnection` class
 - Event handler system
 - Hub connection integration
 
@@ -182,7 +182,7 @@ To fully utilize this feature, the following work is recommended:
 ### .NET
 - `src/ElectronNET.API/Runtime/Data/StartupMethod.cs`
 - `src/ElectronNET.AspNet/Hubs/ElectronHub.cs`
-- `src/ElectronNET.AspNet/Bridge/SignalRFacade.cs`
+- `src/ElectronNET.AspNet/Bridge/SignalRConnection.cs`
 - `src/ElectronNET.AspNet/Runtime/Controllers/RuntimeControllerAspNetDotnetFirstSignalR.cs`
 - `src/ElectronNET.AspNet/API/ElectronEndpointRouteBuilderExtensions.cs`
 - `src/ElectronNET.AspNet/API/WebHostBuilderExtensions.cs`
@@ -200,8 +200,8 @@ To fully utilize this feature, the following work is recommended:
 8ee81f6 - Add ElectronHub and SignalR infrastructure for new startup modes
 40aed60 - Add RuntimeControllerAspNetDotnetFirstSignalR for SignalR-based startup
 c1740b5 - Add SignalR client support to Electron Host for new startup modes
-cb7d721 - Add SignalRFacade for SignalR-based API communication
-268b9c9 - Update RuntimeControllerAspNetDotnetFirstSignalR to use SignalRFacade
+cb7d721 - Add SignalRConnection for SignalR-based API communication
+268b9c9 - Update RuntimeControllerAspNetDotnetFirstSignalR to use SignalRConnection
 04ec522 - Fix compilation errors - Phase 4 complete (basic structure)
 054f5b1 - Complete Phase 5: Add SignalR startup detection and port 0 configuration
 ```
@@ -219,7 +219,7 @@ cb7d721 - Add SignalRFacade for SignalR-based API communication
 
 To contribute to Phase 6 (full API integration):
 
-1. Focus on adapting existing Electron API classes to work with SignalRFacade
+1. Focus on adapting existing Electron API classes to work with SignalRConnection
 2. Implement request-response pattern in ElectronHub
 3. Add integration tests
 4. Create sample applications

src/ElectronNET.API/Bridge/BridgeConnector.cs

@@ -6,7 +6,7 @@ namespace ElectronNET.API
 
     internal static class BridgeConnector
     {
-        public static IFacade Socket
+        public static ISocketConnection Socket
         {
             get
             {

src/ElectronNET.API/Bridge/IFacade.cs …ctronNET.API/Bridge/ISocketConnection.cssrc/ElectronNET.API/Bridge/IFacade.cs renamed to src/ElectronNET.API/Bridge/ISocketConnection.cs src/ElectronNET.API/Bridge/IFacade.cs renamed to src/ElectronNET.API/Bridge/ISocketConnection.cs

@@ -7,7 +7,7 @@ namespace ElectronNET.API.Bridge
     /// Common interface for communication facades (SocketIO and SignalR).
     /// Provides methods for bidirectional communication between .NET and Electron.
     /// </summary>
-    internal interface IFacade
+    internal interface ISocketConnection : IDisposable
     {
         /// <summary>
         /// Raised when the bridge connection is established.
@@ -53,10 +53,5 @@ internal interface IFacade
         /// Sends a message to Electron.
         /// </summary>
         Task Emit(string eventName, params object[] args);
-
-        /// <summary>
-        /// Disposes the connection.
-        /// </summary>
-        void DisposeSocket();
     }
 }

…ElectronNET.API/Bridge/SocketIOFacade.cs …tronNET.API/Bridge/SocketIOConnection.cssrc/ElectronNET.API/Bridge/SocketIOFacade.cs renamed to src/ElectronNET.API/Bridge/SocketIOConnection.cs src/ElectronNET.API/Bridge/SocketIOFacade.cs renamed to src/ElectronNET.API/Bridge/SocketIOConnection.cs

@@ -9,13 +9,13 @@ namespace ElectronNET.API;
 using SocketIO.Serializer.SystemTextJson;
 using SocketIO = SocketIOClient.SocketIO;
 
-internal class SocketIoFacade : IFacade, IDisposable
+internal class SocketIOConnection : ISocketConnection
 {
     private readonly SocketIO _socket;
     private readonly object _lockObj = new object();
     private bool _isDisposed;
 
-    public SocketIoFacade(string uri)
+    public SocketIOConnection(string uri)
     {
         _socket = new SocketIO(uri);
         _socket.Serializer = new SystemTextJsonSerializer(ElectronJson.Options);
@@ -141,7 +141,7 @@ private void CheckDisposed()
     {
         if (this._isDisposed)
         {
-            throw new ObjectDisposedException(nameof(SocketIoFacade));
+            throw new ObjectDisposedException(nameof(SocketIOConnection));
         }
     }
 }

src/ElectronNET.API/ElectronNetRuntime.cs

@@ -50,7 +50,7 @@ static ElectronNetRuntime()
 
         internal static Func<Task> OnAppReadyCallback { get; set; }
 
-        internal static IFacade GetSocket()
+        internal static ISocketConnection GetSocket()
         {
             return RuntimeControllerCore?.Socket;
         }

src/ElectronNET.API/Runtime/Controllers/RuntimeControllerBase.cs

@@ -13,7 +13,7 @@ protected RuntimeControllerBase()
         {
         }
 
-        internal abstract IFacade Socket { get; }
+        internal abstract ISocketConnection Socket { get; }
 
         internal abstract ElectronProcessBase ElectronProcess { get; }
 

src/ElectronNET.API/Runtime/Controllers/RuntimeControllerDotNetFirst.cs

@@ -20,7 +20,7 @@ public RuntimeControllerDotNetFirst()
         {
         }
 
-        internal override IFacade Socket
+        internal override ISocketConnection Socket
         {
             get
             {

src/ElectronNET.API/Runtime/Controllers/RuntimeControllerElectronFirst.cs

@@ -17,7 +17,7 @@ public RuntimeControllerElectronFirst()
         {
         }
 
-        internal override SocketIoFacade Socket
+        internal override SocketIOConnection Socket
         {
             get
             {

src/ElectronNET.API/Runtime/Services/SocketBridge/SocketBridgeService.cs

@@ -9,7 +9,7 @@ internal class SocketBridgeService : LifetimeServiceBase
     {
         private readonly int socketPort;
         private readonly string socketUrl;
-        private SocketIoFacade socket;
+        private SocketIOConnection socket;
 
         public SocketBridgeService(int socketPort)
         {
@@ -19,11 +19,11 @@ public SocketBridgeService(int socketPort)
 
         public int SocketPort => this.socketPort;
 
-        internal SocketIoFacade Socket => this.socket;
+        internal SocketIOConnection Socket => this.socket;
 
         protected override Task StartCore()
         {
-            this.socket = new SocketIoFacade(this.socketUrl);
+            this.socket = new SocketIOConnection(this.socketUrl);
             this.socket.BridgeConnected += this.Socket_BridgeConnected;
             this.socket.BridgeDisconnected += this.Socket_BridgeDisconnected;
             Task.Run(this.Connect);