Misc. minor fixes

Author: javiereguiluz

doc/fields/AssociationField.rst

@@ -62,6 +62,7 @@ method. You can customize this display using either a 1) callback (for simple
 text) or a 2) Twig template (for complex HTML).
 
 .. tip::
+
     If you customize the autocomplete for a given class (for example, ``User``)
     in the same way across different CRUD controllers, you can
     :ref:`configure this globally <crud-autocomplete>` per CRUD and/or Dashboard.

src/Test/AbstractCrudTestCase.php

@@ -24,9 +24,9 @@ abstract class AbstractCrudTestCase extends WebTestCase
     use CrudTestIndexAsserts;
     use CrudTestUrlGeneration;
 
-    protected KernelBrowser $client;
-    protected AdminUrlGeneratorInterface $adminUrlGenerator;
-    protected EntityManagerInterface $entityManager;
+    protected ?KernelBrowser $client = null;
+    protected ?AdminUrlGeneratorInterface $adminUrlGenerator = null;
+    protected ?EntityManagerInterface $entityManager = null;
 
     protected function setUp(): void
     {
@@ -44,12 +44,14 @@ protected function setUp(): void
 
     protected function tearDown(): void
     {
-        if (isset($this->entityManager) && $this->entityManager->isOpen()) {
+        if (null !== $this->entityManager && $this->entityManager->isOpen()) {
             $this->entityManager->clear();
             $this->entityManager->getConnection()->close();
         }
 
-        unset($this->client, $this->entityManager, $this->adminUrlGenerator);
+        $this->client = null;
+        $this->entityManager = null;
+        $this->adminUrlGenerator = null;
 
         parent::tearDown();
 

tests/Functional/Apps/DefaultApp/translations/messages.en.php

@@ -2,7 +2,7 @@
 
 return [
     'entities' => [
-        \EasyCorp\Bundle\EasyAdminBundle\Tests\Functional\Apps\DefaultApp\Entity\Category::class => [
+        EasyCorp\Bundle\EasyAdminBundle\Tests\Functional\Apps\DefaultApp\Entity\Category::class => [
             'singular' => 'Category (singular from file)',
             'plural' => 'Categories (plural from file)',
             'properties' => [

tests/Functional/Default/Dashboard/EntityTranslationsTest.php

@@ -52,7 +52,7 @@ public function testTranslatedLabelsAppearedInTableHeaders(): void
         $tableHeaders = $crawler->filter('table.datagrid thead th');
 
         $headerTexts = [];
-        $tableHeaders->each(function ($node) use (&$headerTexts) {
+        $tableHeaders->each(static function ($node) use (&$headerTexts) {
             $headerTexts[] = trim($node->text());
         });
 
@@ -70,7 +70,7 @@ public function testMenuItemUsesEntityPluralTranslation(): void
         // when menu item label is null, it should use the entity's plural translation
         $menuItems = $crawler->filter('.menu-item a');
         $menuTexts = [];
-        $menuItems->each(function ($node) use (&$menuTexts) {
+        $menuItems->each(static function ($node) use (&$menuTexts) {
             $menuTexts[] = trim($node->text());
         });