Fix for nullable fields on new models

Author: hparadiz

src/Models/ActiveRecord.php

@@ -1648,7 +1648,11 @@ protected function _setFieldValue($field, $value)
                 }
         }
 
-        if ($forceDirty || (empty($this->_record[$field]) && isset($value)) || ($this->_record[$field] !== $value)) {
+        $columnName = static::_cn($field);
+        $recordHasValue = array_key_exists($columnName, $this->_record);
+        $currentValue = $recordHasValue ? $this->_record[$columnName] : null;
+
+        if ($forceDirty || (!$recordHasValue && isset($value)) || ($recordHasValue && $currentValue !== $value)) {
             $this->_setValueAndMarkDirty($field, $value, $fieldOptions);
             return true;
         } else {

tests/Divergence/Models/ActiveRecordTest.php

@@ -715,6 +715,17 @@ public function testSaveCanaryTimestamps()
         $this->assertNull($x->DateOfBirth);
     }
 
+    public function testNewCanaryAllowsNullableFieldsToBeSetWithoutWarnings()
+    {
+        $Canary = new Canary();
+
+        $Canary->Handle = null;
+        $Canary->LongestFlightTime = null;
+
+        $this->assertNull($Canary->Handle);
+        $this->assertNull($Canary->LongestFlightTime);
+    }
+
     /**
      *
      *