Skip to content

Commit 13f8a46

Browse files
committed
Make pyright happy
1 parent 931932c commit 13f8a46

4 files changed

Lines changed: 9 additions & 7 deletions

File tree

src/mx_bluesky/beamlines/i04/experiment_plans/i04_grid_detect_then_xray_centre_plan.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,8 @@ def grid_detect_then_xray_centre_with_callbacks():
261261

262262
try:
263263
yield from get_results_and_move_to_xtal(
264-
composite,
264+
composite.gonio,
265+
composite.zocalo,
265266
internal_params,
266267
grid_scan_params,
267268
flyscan_event_handler,

src/mx_bluesky/common/experiment_plans/change_aperture_then_move_plan.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
)
1414
from mx_bluesky.common.parameters.components import WithSample
1515
from mx_bluesky.common.parameters.constants import PlanGroupCheckpointConstants
16-
from mx_bluesky.common.parameters.device_composites import FlyScanEssentialDevices
1716
from mx_bluesky.common.parameters.gridscan import (
1817
GridScanParams,
1918
)
@@ -39,15 +38,16 @@ def _get_xrc_results(
3938

4039

4140
def get_results_and_move_to_xtal(
42-
composite: FlyScanEssentialDevices[Smargon],
41+
gonio: Smargon,
42+
zocalo: ZocaloResults,
4343
parameters: WithSample,
4444
grid_scan_params: GridScanParams,
4545
flyscan_event_handler: XRayCentreEventHandler,
4646
):
4747
flyscan_results = yield from _get_xrc_results(
48-
composite.zocalo, parameters, grid_scan_params, flyscan_event_handler
48+
zocalo, parameters, grid_scan_params, flyscan_event_handler
4949
)
50-
yield from move_to_xtal(flyscan_results[0], composite.gonio)
50+
yield from move_to_xtal(flyscan_results[0], gonio)
5151

5252

5353
def change_aperture(

src/mx_bluesky/hyperion/external_interaction/callbacks/rotation/nexus_callback.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ def activity_gated_start(self, doc: RunStart):
9292
parameters.detector_params.detector_size_constants.det_size_pixels
9393
)
9494
shape = (parameters.num_images, det_size.width, det_size.height)
95+
assert self.full_num_of_images
9596
self.writer = NexusWriter(
9697
parameters,
9798
parameters.detector_params,

tests/unit_tests/beamlines/i04/test_i04_grid_detect_then_xray_centre_plan.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -634,10 +634,10 @@ def test_detect_grid_and_do_gridscan_gives_params_specified_grid(
634634
)
635635
mock_get_results_and_move_to_xtal.assert_called_once()
636636
assert (
637-
mock_get_results_and_move_to_xtal.call_args[0][1]
637+
mock_get_results_and_move_to_xtal.call_args[0][2]
638638
== minimal_diffraction_expt_with_sample
639639
)
640-
assert mock_get_results_and_move_to_xtal.call_args[0][2] == i04_grid_scan_params
640+
assert mock_get_results_and_move_to_xtal.call_args[0][3] == i04_grid_scan_params
641641

642642

643643
@patch(

0 commit comments

Comments
 (0)