-
Notifications
You must be signed in to change notification settings - Fork 922
Expand file tree
/
Copy pathShimStandardInputTests.cs
More file actions
225 lines (196 loc) · 7.05 KB
/
Copy pathShimStandardInputTests.cs
File metadata and controls
225 lines (196 loc) · 7.05 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
#if WINDOWS
using System.Diagnostics;
using UniGetUI.Core.Data;
using UniGetUI.Core.SettingsEngine.SecureSettings;
using UniGetUI.Core.SettingsEngine;
using UniGetUI.PackageEngine.Enums;
using UniGetUI.PackageOperations;
using UniGetUI.Core.Tools;
namespace UniGetUI.PackageEngine.Tests;
/// <summary>
/// The npm and Scoop PowerShell shims pipe $input to the real program whenever standard input is
/// not a console, and enumerating $input blocks until that pipe is closed. Launching such a shim
/// with a redirected pipe left open therefore hangs forever instead of running the command, which
/// is what a package search through npm did once it was moved to the -File launch path.
/// <para>
/// These tests drive a stand-in shim carrying the same branch through the real powershell.exe, so
/// they reproduce the hang without needing npm or Scoop installed.
/// </para>
/// </summary>
public sealed class ShimStandardInputTests : IDisposable
{
private readonly string _testRoot;
private readonly string _shimPath;
public ShimStandardInputTests()
{
_testRoot = Path.Combine(
Path.GetTempPath(),
nameof(ShimStandardInputTests),
Guid.NewGuid().ToString("N")
);
string secureSettingsRoot = Path.Combine(_testRoot, "SecureSettings");
CoreData.TEST_DataDirectoryOverride = Path.Combine(_testRoot, "Data");
SecureSettings.TEST_SecureSettingsRootOverride = secureSettingsRoot;
Directory.CreateDirectory(_testRoot);
Directory.CreateDirectory(CoreData.UniGetUIUserConfigurationDirectory);
Directory.CreateDirectory(secureSettingsRoot);
Settings.ResetSettings();
_shimPath = Path.Combine(_testRoot, "shim.ps1");
File.WriteAllText(
_shimPath,
"""
if ($MyInvocation.ExpectingInput) { $input | Out-Null; "ran:$args" }
else { "ran:$args" }
"""
);
}
public void Dispose()
{
Settings.ResetSettings();
CoreData.TEST_DataDirectoryOverride = null;
SecureSettings.TEST_SecureSettingsRootOverride = null;
try
{
if (Directory.Exists(_testRoot))
Directory.Delete(_testRoot, recursive: true);
}
catch (IOException) { }
}
private static string PowerShellPath() =>
Path.Combine(
Environment.GetFolderPath(Environment.SpecialFolder.System),
"WindowsPowerShell",
"v1.0",
"powershell.exe"
);
private Process StartShim()
{
var startInfo = new ProcessStartInfo
{
FileName = PowerShellPath(),
UseShellExecute = false,
RedirectStandardInput = true,
RedirectStandardOutput = true,
RedirectStandardError = true,
CreateNoWindow = true,
};
foreach (
string argument in new[]
{
"-NoProfile",
"-ExecutionPolicy",
"Bypass",
"-File",
_shimPath,
"search",
"cowsay",
}
)
startInfo.ArgumentList.Add(argument);
return new Process { StartInfo = startInfo };
}
[Fact]
public async Task AShimRunsWhenTheHelperClosesStandardInput()
{
using Process process = StartShim();
CoreTools.StartAndCloseStandardInput(process);
Task<string> output = process.StandardOutput.ReadToEndAsync();
using var timeout = new CancellationTokenSource(TimeSpan.FromSeconds(30));
await process.WaitForExitAsync(timeout.Token);
Assert.Equal(0, process.ExitCode);
Assert.Contains("ran:search cowsay", await output);
}
[Fact]
public void AShimHangsWhenStandardInputIsLeftOpen()
{
using Process process = StartShim();
process.Start();
try
{
Assert.False(
process.WaitForExit(5000),
"The shim completed with its standard input left open, so the helper is no longer "
+ "what keeps the npm and Scoop launch paths alive."
);
}
finally
{
process.Kill(entireProcessTree: true);
}
}
[Fact]
public void TheHelperLeavesAProcessWithoutARedirectedStandardInputAlone()
{
var startInfo = new ProcessStartInfo
{
FileName = PowerShellPath(),
UseShellExecute = false,
RedirectStandardOutput = true,
CreateNoWindow = true,
};
foreach (string argument in new[] { "-NoProfile", "-Command", "exit 0" })
startInfo.ArgumentList.Add(argument);
using var process = new Process { StartInfo = startInfo };
CoreTools.StartAndCloseStandardInput(process);
Assert.True(process.WaitForExit(30000));
Assert.Equal(0, process.ExitCode);
}
[Theory]
[InlineData(false)]
[InlineData(true)]
public async Task AProcessOperationClosesStandardInputWhicheverWayTheLineHandlerIsSet(
bool disableLineHandler
)
{
Settings.Set(Settings.K.DisableNewProcessLineHandler, disableLineHandler);
using var operation = new ShimOperation(PowerShellPath(), _shimPath);
Task run = operation.MainThread();
using var timeout = new CancellationTokenSource(TimeSpan.FromSeconds(60));
await run.WaitAsync(timeout.Token);
Assert.Equal(OperationStatus.Succeeded, operation.Status);
}
private sealed class ShimOperation : AbstractProcessOperation
{
private readonly string _powerShell;
private readonly string _shim;
public ShimOperation(string powerShell, string shim)
: base(queue_enabled: false)
{
_powerShell = powerShell;
_shim = shim;
Metadata.Title = "Shim standard input";
Metadata.Status = "Running the shim";
Metadata.OperationInformation = "Shim standard input";
Metadata.SuccessTitle = "Succeeded";
Metadata.SuccessMessage = "Succeeded";
Metadata.FailureTitle = "Failed";
Metadata.FailureMessage = "Failed";
}
protected override void ApplyRetryAction(string retryMode) { }
public override Task<Uri> GetOperationIcon() =>
Task.FromResult(new Uri("about:blank"));
protected override void PrepareProcessStartInfo()
{
process.StartInfo.FileName = _powerShell;
SetArgumentVector(
[
"-NoProfile",
"-ExecutionPolicy",
"Bypass",
"-File",
_shim,
"search",
"cowsay",
]
);
}
protected override Task<OperationVeredict> GetProcessVeredict(
int ReturnCode,
List<string> Output
) =>
Task.FromResult(
ReturnCode == 0 ? OperationVeredict.Success : OperationVeredict.Failure
);
}
}
#endif