Merge issue-224-deterministic-fixtures: stabilize calendar and search test fixtures (#224)

Author: alexeygrigorev

backend/e2e/canonical-route-parity.spec.js

@@ -2,6 +2,7 @@ const { test, expect } = require('@playwright/test');
 const { recordCapabilityEvidence } = require('./helpers/capability-evidence');
 const AxeBuilder = require('@axe-core/playwright').default;
 const path = require('path');
+const { offsetBusinessDate } = require('./helpers/business-date');
 
 const SHOTS = path.resolve(__dirname, '..', '..', '.tmp', 'screenshots', 'issue-156');
 
@@ -16,7 +17,7 @@ function berlinToday() {
   return `${parts.year}-${parts.month}-${parts.day}`;
 }
 
-async function createFixtures(request) {
+async function createFixtures(request, referenceTime = Date.now()) {
   const id = suffix();
   const card = (await (await request.post('/api/cards', {
     data: { title: `Route workflow ${id}`, anchorDate: '2026-08-11' },
@@ -34,10 +35,10 @@ async function createFixtures(request) {
     data: { source: 'manual', title: `Blocked intake ${id}`, note: 'Waiting on a synthetic reply', dataClass: 'internal' },
   })).json()).item;
   await request.post(`/api/intake/${blocked.id}/block`, {
-    data: { reason: 'Need a response', waitingFor: 'Synthetic partner', followUpAt: '2026-08-01T09:00:00.000Z' },
+    data: { reason: 'Need a response', waitingFor: 'Synthetic partner', followUpAt: `${offsetBusinessDate(referenceTime, -2)}T09:00:00.000Z` },
   });
   await request.post(`/api/intake/${blocked.id}/follow-up-sent`, {
-    data: { note: 'Sent a synthetic reminder', nextFollowUpAt: '2026-08-10T09:00:00.000Z', channel: 'email' },
+    data: { note: 'Sent a synthetic reminder', nextFollowUpAt: `${offsetBusinessDate(referenceTime, -1)}T09:00:00.000Z`, channel: 'email' },
   });
   const filteredOut = (await (await request.post('/api/intake', {
     data: { source: 'manual', title: `Archived intake ${id}`, note: 'Genuinely outside the actionable filter', dataClass: 'internal' },
@@ -640,7 +641,8 @@ test.describe('issue 156 canonical route and operator parity', () => {
   });
 
   test('provides mobile Inbox, dismissal, recurring delete, sign-out, a11y, and exact screenshot evidence', async ({ page, request }, testInfo) => {
-    const fixture = await createFixtures(request);
+    const referenceTime = Date.now();
+    const fixture = await createFixtures(request, referenceTime);
     const createStateIntake = async (label) => (await (await request.post('/api/intake', {
       data: { source: 'manual', title: `${label} ${fixture.id}`, note: `Synthetic ${label.toLowerCase()} context`, dataClass: 'internal' },
     })).json()).item;
@@ -662,7 +664,7 @@ test.describe('issue 156 canonical route and operator parity', () => {
     })).json()).item;
     const futureBlockedSource = await createStateIntake('Future blocked intake');
     const futureBlocked = (await (await request.post(`/api/intake/${futureBlockedSource.id}/block`, {
-      data: { reason: 'Future synthetic wait', waitingFor: 'Synthetic partner', followUpAt: '2026-09-01T09:00:00.000Z' },
+      data: { reason: 'Future synthetic wait', waitingFor: 'Synthetic partner', followUpAt: `${offsetBusinessDate(referenceTime, 2)}T09:00:00.000Z` },
     })).json()).item;
 
     await page.setViewportSize({ width: 1440, height: 900 });

backend/tests/conversational-execution.test.ts

@@ -1,6 +1,7 @@
 import { after, before, describe, it } from 'node:test';
 import assert from 'node:assert';
 import { GetCommand, QueryCommand, type DynamoDBDocumentClient } from '@aws-sdk/lib-dynamodb';
+import { useFixedDate } from './helpers/fixed-date';
 
 import { getClient } from '../src/db/client';
 import {
@@ -112,6 +113,7 @@ function event(
 }
 
 describe('transactional conversational approval and durable execution', () => {
+  useFixedDate(NOW);
   let client: DynamoDBDocumentClient;
   let sequence = 0;
 

backend/tests/conversational-state.test.ts

@@ -3,6 +3,7 @@ import assert from 'node:assert';
 import fs from 'fs/promises';
 import path from 'path';
 import type { DynamoDBDocumentClient } from '@aws-sdk/lib-dynamodb';
+import { useFixedDate } from './helpers/fixed-date';
 
 import { getClient } from '../src/db/client';
 import { startLocal, stopLocal } from '../scripts/local-dynamodb';
@@ -163,6 +164,7 @@ function attempt(conversationId: string): ExecutionAttempt {
 }
 
 describe('conversational state persistence', () => {
+  useFixedDate(NOW_DATE);
   let client: DynamoDBDocumentClient;
   const generatedDirs: string[] = [];
 

backend/tests/docs-search.test.ts

@@ -2,7 +2,7 @@ import { describe, it, before, after } from 'node:test';
 import assert from 'node:assert';
 import { mkdtempSync, rmSync } from 'node:fs';
 import { tmpdir } from 'node:os';
-import { join, resolve } from 'node:path';
+import { join } from 'node:path';
 
 import {
   createSearchIndex,
@@ -13,10 +13,8 @@ import {
   type SearchDocument,
   type SearchResult,
 } from '../src/docs/searchIndex';
-import { extractDoc, iterContentDocs } from '../src/docs/search/extract';
-import { findContentRoot } from './helpers/content';
+import { extractDoc } from '../src/docs/search/extract';
 
-const CONTENT_DIR = findContentRoot();
 const paths = (results: SearchResult[]): string[] => results.map((r) => String(r.path));
 
 describe('docs search - field config (parity with docs_index.py)', () => {
@@ -144,51 +142,39 @@ describe('docs search - save/load round-trip (json-1)', () => {
   });
 });
 
-// Smoke fixtures updated for TF-IDF (minsearch) -> BM25-lite (zerosearch).
-// Captured against a minsearch top-k baseline: top-1 is identical for every
-// query below; ordering shifts inside the relevant set, recall stays on par
-// (see issue #85 notes). Each fixture asserts the BM25-lite top-1 plus a doc
-// that must remain in the top-5 (recall guard).
-const SMOKE: { query: string; top1: string; recall: string }[] = [
-  {
-    query: 'podcast intake',
-    top1: 'content/media/podcast/templates/podcast-share-the-podcast-page-template.md',
-    recall: 'content/tasks/templates/podcast.md',
-  },
-  {
-    query: 'newsletter sponsor',
-    top1: 'content/overview/reference/newsletter.md',
-    recall: 'content/newsletter/sponsorship/sops/creating-a-document-for-sponsored-content-for-a-newsletter.md',
-  },
-  {
-    query: 'course certificate',
-    top1: 'content/tasks/templates/course.md',
-    recall: 'content/courses/reference/course-guide.md',
-  },
-  {
-    query: 'youtube upload',
-    top1: 'content/media/open-source-spotlight/reference/for-update-download-open-source-spotlight-video-from-zoom-and-upload-it-to-youtube.md',
-    recall: 'content/media/video-youtube/sops/downloading-and-uploading-videos-from-loom-to-youtube.md',
-  },
+// Public synthetic relevance fixtures: title/summary matches should outrank
+// incidental single-word matches, while related body text remains discoverable.
+const SMOKE = [
+  { query: 'podcast intake', title: 'Podcast intake checklist', related: 'Recording preparation', distractor: 'Podcast audio settings' },
+  { query: 'newsletter sponsor', title: 'Newsletter sponsor overview', related: 'Publication planning', distractor: 'Newsletter typography' },
+  { query: 'course certificate', title: 'Course certificate guide', related: 'Completion records', distractor: 'Course exercises' },
+  { query: 'youtube upload', title: 'YouTube upload checklist', related: 'Video preparation', distractor: 'YouTube analytics' },
 ];
 
-describe('docs search - smoke query relevance over the document corpus (BM25-lite)', () => {
-  // The corpus lives in the private knowledge repository, so these rank real
-  // documents only when it is checked out.
-  let index: ReturnType<typeof createSearchIndex>;
-  before(() => {
-    if (!CONTENT_DIR) return;
-    const docs = iterContentDocs(CONTENT_DIR);
-    index = createSearchIndex().fit(docs);
-  });
-
-  for (const { query, top1, recall } of SMOKE) {
-    it(`ranks the expected doc first and keeps recall for "${query}"`, (t) => {
-      if (!CONTENT_DIR) return t.skip('knowledge repository not checked out');
+describe('docs search - smoke query relevance over a public synthetic corpus (BM25-lite)', () => {
+  const corpus: SearchDocument[] = SMOKE.flatMap(({ query, title, related, distractor }, index) => [
+    {
+      path: `synthetic/topic-${index}/overview.md`, id: `overview-${index}`,
+      title, summary: `A synthetic overview of ${query}.`,
+      body: 'Reference material for a test topic.',
+    },
+    {
+      path: `synthetic/topic-${index}/related.md`, id: `related-${index}`,
+      title: related, body: `This synthetic reference also discusses ${query}.`,
+    },
+    {
+      path: `synthetic/topic-${index}/incidental.md`, id: `incidental-${index}`,
+      title: distractor, body: 'A separate topic with only an incidental keyword match.',
+    },
+  ]);
+  const index = createSearchIndex().fit(corpus);
+
+  for (const [topic, { query }] of SMOKE.entries()) {
+    it(`ranks the expected doc first and keeps recall for "${query}"`, () => {
       const results = index.search(query, { numResults: 5 });
-      assert.ok(results.length > 0, 'expected at least one result');
-      assert.strictEqual(results[0].path, top1, `top-1 for "${query}"`);
-      assert.ok(paths(results).includes(recall), `"${recall}" should be in top-5 for "${query}"`);
+      assert.strictEqual(results[0]?.path, `synthetic/topic-${topic}/overview.md`, `top-1 for "${query}"`);
+      assert.ok(paths(results).includes(`synthetic/topic-${topic}/related.md`), 'related body-text match remains in top-5');
+      assert.ok(paths(results).includes(`synthetic/topic-${topic}/incidental.md`), 'a competing single-term document was also searched');
     });
   }
 });

backend/tests/helpers/fixed-date.ts

@@ -0,0 +1,13 @@
+import { after, before, mock } from 'node:test';
+
+/** Fix only wall-clock Date inside this suite; async/database timers stay real. */
+export function useFixedDate(now: Date): void {
+  // Runtime CI uses Node 20+, whose Date-only timer API is newer than the
+  // project's Node 18 type declarations. Keep this type bridge test-local.
+  const timers = mock.timers as unknown as {
+    enable(options: { apis: ['Date']; now: Date }): void;
+    reset(): void;
+  };
+  before(() => timers.enable({ apis: ['Date'], now }));
+  after(() => timers.reset());
+}

backend/tests/telegram-conversational.test.ts

@@ -4,6 +4,7 @@ import { mkdir, readdir, rm, symlink, utimes, writeFile } from 'fs/promises';
 import path from 'path';
 import { encode as encodeJpeg } from 'jpeg-js';
 import { PutCommand, QueryCommand, type DynamoDBDocumentClient } from '@aws-sdk/lib-dynamodb';
+import { useFixedDate } from './helpers/fixed-date';
 
 import { getClient } from '../src/db/client';
 import { startLocal, stopLocal } from '../scripts/local-dynamodb';
@@ -188,6 +189,7 @@ class FakeCore implements TelegramCoreRuntime {
 }
 
 describe('private conversational Telegram adapter', () => {
+  useFixedDate(NOW);
   let client: Awaited<ReturnType<typeof getClient>>;
   let telegram: FakeTelegram;
   let core: FakeCore;
@@ -1138,9 +1140,9 @@ describe('private conversational Telegram adapter', () => {
       })
     )) as typeof fetch;
     const hangingTelegram = new HttpTelegramClient('fake', 100, 1024, hangingFetch);
-    const started = Date.now();
+    const started = performance.now();
     await assert.rejects(() => hangingTelegram.getFile('safe-file'));
-    assert.ok(Date.now() - started < 1_000);
+    assert.ok(performance.now() - started < 1_000);
 
     let telegramCalls = 0;
     const oversizedFetch = (async () => {