Handle FAQ assistant outages

Author: alexeygrigorev

automator/src/lambda_function.py

@@ -18,6 +18,14 @@
 FAQ_ASSISTANT_URL = os.getenv('FAQ_ASSISTANT_URL', '').strip()
 FAQ_ASSISTANT_SHARED_SECRET = os.getenv('FAQ_ASSISTANT_SHARED_SECRET', '')
 FAQ_ASSISTANT_TIMEOUT = int(os.getenv('FAQ_ASSISTANT_TIMEOUT', '55'))
+FAQ_ASSISTANT_ERROR_MESSAGE = (
+    'The FAQ assistant is currently not available. '
+    'In the meantime, you can try to find the answer here:'
+)
+FAQ_ASSISTANT_GENERIC_RESOURCES = {
+    'docs': 'https://datatalks.club/docs/',
+    'faq': 'https://datatalks.club/faq/',
+}
 
 
 
@@ -93,6 +101,33 @@ def call_faq_assistant(payload):
     return response.json()
 
 
+def faq_assistant_fallback_resources(payload):
+    course = payload.get('course')
+    if not course:
+        return FAQ_ASSISTANT_GENERIC_RESOURCES
+
+    return {
+        'docs': f'https://datatalks.club/docs/courses/{course}/',
+        'faq': f'https://datatalks.club/faq/{course}.html',
+        'repo': f'https://github.com/DataTalksClub/{course}',
+    }
+
+
+def format_faq_assistant_error_message(payload):
+    resources = faq_assistant_fallback_resources(payload)
+    lines = [
+        f"- <{resources['docs']}|Docs>",
+        f"- <{resources['faq']}|FAQ>",
+    ]
+    if resources.get('repo'):
+        lines.append(f"- <{resources['repo']}|Course repo>")
+
+    return (
+        f'{FAQ_ASSISTANT_ERROR_MESSAGE}\n\n'
+        + '\n'.join(lines)
+    )
+
+
 def post_faq_assistant_answer(channel, thread_ts, payload):
     if not channel or not thread_ts:
         logger.info('FAQ assistant request missing channel or ts')
@@ -109,7 +144,21 @@ def post_faq_assistant_answer(channel, thread_ts, payload):
         f"FAQ assistant request: scope={payload['scope']} "
         f"course={payload.get('course', '')}"
     )
-    answer = call_faq_assistant(payload)
+    try:
+        answer = call_faq_assistant(payload)
+    except requests.RequestException as exc:
+        response = getattr(exc, 'response', None)
+        status = getattr(response, 'status_code', None)
+        body = getattr(response, 'text', '') if response is not None else ''
+        logger.info(
+            f"FAQ assistant request failed: status={status} "
+            f"error={exc} body={body[:500]}"
+        )
+        slack.post_message_to_thread(
+            channel, thread_ts, format_faq_assistant_error_message(payload)
+        )
+        return
+
     if not answer:
         return
 

automator/tests/test_automator_lambda.py

@@ -1103,6 +1103,49 @@ def test_handle_app_mention_appends_sources(self, mock_call, mock_slack):
         self.assertIn('*Sources:*', posted)
         self.assertIn('<https://datatalks.club/faq/llm-zoomcamp.html#abc|Joining>', posted)
 
+    @patch('automator_lambda_function.slack')
+    @patch('automator_lambda_function.call_faq_assistant')
+    def test_faq_assistant_failure_posts_error_without_raising(self, mock_call, mock_slack):
+        response = MagicMock()
+        response.status_code = 500
+        response.text = 'upstream exploded'
+        mock_call.side_effect = lambda_function.requests.exceptions.HTTPError(
+            '500 Server Error', response=response
+        )
+
+        lambda_function.post_faq_assistant_answer(
+            'C06TEGTGM3J',
+            '1790000000.000100',
+            {
+                'question': 'Can I still join?',
+                'scope': 'course',
+                'course': 'llm-zoomcamp',
+            },
+        )
+
+        mock_slack.github_to_slack_markdown.assert_not_called()
+        posted = mock_slack.post_message_to_thread.call_args[0][2]
+        self.assertIn('The FAQ assistant is currently not available.', posted)
+        self.assertIn('In the meantime, you can try to find the answer here:', posted)
+        self.assertIn('<https://datatalks.club/docs/courses/llm-zoomcamp/|Docs>', posted)
+        self.assertIn('<https://datatalks.club/faq/llm-zoomcamp.html|FAQ>', posted)
+        self.assertIn('<https://github.com/DataTalksClub/llm-zoomcamp|Course repo>', posted)
+        mock_slack.post_message_to_thread.assert_called_once_with(
+            'C06TEGTGM3J',
+            '1790000000.000100',
+            posted,
+        )
+
+    def test_faq_assistant_error_message_uses_generic_resources_without_course(self):
+        message = lambda_function.format_faq_assistant_error_message({
+            'question': 'How do I join Slack?',
+            'scope': 'docs',
+        })
+
+        self.assertIn('<https://datatalks.club/docs/|Docs>', message)
+        self.assertIn('<https://datatalks.club/faq/|FAQ>', message)
+        self.assertNotIn('Course repo', message)
+
     def test_faq_reaction_config_uses_faq_assistant(self):
         reaction_config = lambda_function.reaction_configs.get('faq')
         self.assertIsNotNone(reaction_config)