feat(app:socket.io): build socket.io into vendor.js

[kingcody]

Changes:

• Move socket.io script tag inside vendor.js build
• Add node_modules/socket.io/node_modules to vendor script locations
• Change socket.io path to /socket.io-client in serve and client
• Will not serve socket.io.js when server is ran in production env

[DaftMonk]

grunt-changelog can't parse commits with colons in the scope i.e: (app:socket.io)

Could you change the commit message?

[kingcody]

Doh! Sorry, will do.

One quick thought...
I use a build path of node_modules/socket.io/node_modules because socket.io requires socket.io-client and everything lines up nicely. My only addition would be to include socket.io-client in out package.json and use a build dir of node_modules instead. Reason being that if socket.io changed the order in which they included socket.io-client, our build would most likely break. But if we require it then we know it will be in top level node_modules and most likely npm will skip it as dep for socket.io since it was installed by a parent dep.

[DaftMonk]

👍 Sounds good.

[kingcody]

@DaftMonk, in client/index.html the opening <script> for the google analytics and the script body itself are indented one space too many. Would you mind fixing that? Or should I add it to this PR?

[DaftMonk]

Thats ok, I got it.

[meeDamian]

@kingcody What happens, here? I'm confused.

[kingcody]

We moved the socket.io script tag inside the usemin build block so it will get included in vendor.js. We add node_modules to the search glob for the build, and change the path to socket.io-client/... since we install socket.io-client as a dependency. That way the paths all line up nicely and we still use the same script that socket.io would serve.

[meeDamian]

ok, thank you :)

[kingcody]

If you take a look at the server and client scripts where we setup socket.io, you should see where we've adjusted the paths to match.