support Smart lifecycle aliases and schema unions

Author: Coding-Dev-Tools

integrations/prime_agent/src/engraphis_prime_agent/agent.py

@@ -378,6 +378,10 @@ async def _dispatch_session_lifecycle(
         the server's session state.
         """
         action = args.get("action", "start")
+        action = {
+            "start_session": "start",
+            "end_session": "end",
+        }.get(action, action)
         if action not in {"start", "end"}:
             raise EngraphisMcpToolError(
                 "engraphis_session action must be 'start' or 'end'."

integrations/prime_agent/src/engraphis_prime_agent/tools.py

@@ -357,15 +357,15 @@ def _coerce_type(value: Any, declared: Any) -> bool:
         declared = [declared]
     # bool is a subclass of int in Python; reject it where the schema
     # says "integer" / "number" so a stray `True` is not silently accepted.
-    for t in declared:
-        py = _TYPE_RANK.get(t)
-        if py is None:
-            continue
-        if t in ("integer", "number") and isinstance(value, bool):
-            return False
-        if not isinstance(value, py):
-            return False
-    return True
+    for t in declared:
+        py = _TYPE_RANK.get(t)
+        if py is None:
+            continue
+        if t in ("integer", "number") and isinstance(value, bool):
+            continue
+        if isinstance(value, py):
+            return True
+    return False
 
 
 def _validate_schema(schema: dict[str, Any], value: Any, path: str = "") -> list[str]:

integrations/prime_agent/tests/test_fleet.py

@@ -227,6 +227,15 @@ async def test_lifecycle_rejects_unknown_action(fleet) -> None:
         await fleet["researcher"].call("engraphis_session", {"action": "resume"})
 
 
+@pytest.mark.asyncio
+async def test_lifecycle_accepts_compatibility_action_aliases(fleet) -> None:
+    agent = fleet["researcher"]
+    await agent.call("engraphis_session", {"action": "start_session"})
+    assert agent.session_id is not None
+    await agent.call("engraphis_session", {"action": "end_session"})
+    assert agent.session_id is None
+
+
 @pytest.mark.asyncio
 async def test_lifecycle_rejects_non_boolean_force_new(fleet) -> None:
     with pytest.raises(EngraphisMcpToolError, match="force_new must be a boolean"):

integrations/prime_agent/tests/test_tools.py

@@ -10,6 +10,7 @@
     all_tools,
     apply_scope_defaults,
     build_tool,
+    validate_args,
 )
 
 
@@ -57,6 +58,11 @@ def test_session_agent_is_optional_for_registered_lifecycle_calls() -> None:
     assert "agent" not in schema["required"]
 
 
+def test_nullable_schema_types_accept_each_union_member() -> None:
+    assert validate_args("engraphis_session", {"repo": "api"})["repo"] == "api"
+    assert validate_args("engraphis_session", {"repo": None})["repo"] is None
+
+
 def test_build_tool_unknown_name_raises() -> None:
     config = EngraphisRuntimeConfig(command="x")
     client = EngraphisMcpClient(config)