Fix moveBack() to move the history pointer instead of appending

`moveBack()` replayed the previous request through `_loadPage()`, which
called `clientRequest()` with the default `$changeHistory = true`. That
appended a new entry to the BrowserKit history and discarded the forward
entries, so going back behaved like a fresh navigation rather than a real
Back button: the history pointer ended up on the last page again and a
second `moveBack()` no longer walked further back.

Thread a `$changeHistory` flag through `_loadPage()` (default `true`, so it
is backward compatible) and pass `false` from `moveBack()`. The replayed
request no longer mutates the history, matching Symfony's native
`AbstractBrowser::back()` semantics.

This also makes the framework history assertions
(`assertBrowserHistoryIsNotOnLastPage()`) observable through the public
`moveBack()` step.

Author: Aaron Gustavo Nieves

src/Codeception/Lib/InnerBrowser.php

@@ -280,9 +280,10 @@ public function _loadPage(
         array $parameters = [],
         array $files = [],
         array $server = [],
-        ?string $content = null
+        ?string $content = null,
+        bool $changeHistory = true
     ): void {
-        $this->crawler = $this->clientRequest($method, $uri, $parameters, $files, $server, $content);
+        $this->crawler = $this->clientRequest($method, $uri, $parameters, $files, $server, $content, $changeHistory);
         $this->baseUrl = $this->retrieveBaseUrl();
         $this->forms = [];
     }
@@ -2000,13 +2001,17 @@ public function moveBack(int $numberOfSteps = 1): void
             ), $exception->getCode(), $exception);
         }
 
+        // Replay the previous request without appending to the history, so the
+        // browser history pointer moves back (like a real Back button) instead of
+        // pushing a new entry and discarding the forward entries.
         $this->_loadPage(
             $request->getMethod(),
             $request->getUri(),
             $request->getParameters(),
             $request->getFiles(),
             $request->getServer(),
-            $request->getContent()
+            $request->getContent(),
+            false
         );
     }
 

tests/data/app/db

@@ -1 +1 @@
-a:0:{}
+a:4:{s:6:"params";a:0:{}s:5:"query";a:0:{}s:4:"form";a:4:{s:8:"wireless";s:5:"mouse";s:6:"coffee";s:1:"0";s:3:"tea";s:1:"1";s:7:"vanilla";s:2:"on";}s:5:"files";a:0:{}}

tests/unit/Codeception/Module/FrameworksTest.php

@@ -68,6 +68,17 @@ public function testMoveBackTwoSteps()
         $this->module->seeCurrentUrlEquals('/iframe');
     }
 
+    public function testMoveBackPreservesForwardHistory()
+    {
+        $this->module->amOnPage('/iframe');
+        $this->module->amOnPage('/info');
+        $this->module->amOnPage('/');
+        $this->module->moveBack();
+        $this->module->seeCurrentUrlEquals('/info');
+        $this->module->moveBack();
+        $this->module->seeCurrentUrlEquals('/iframe');
+    }
+
     public function testMoveBackThrowsExceptionIfNumberOfStepsIsInvalid()
     {
         $this->module->amOnPage('/iframe');