clean up label checks

Author: MattyTheHacker

src/autoupdater.ts

@@ -505,8 +505,6 @@ export class AutoUpdater {
                 .map((l: any) => l.name)
                 .filter(Boolean);
 
-              // Check that the label exists on the remote before applying it
-              let labelExists = true;
               try {
                 await this.octokit.rest.issues.getLabel({
                   owner: mergeOpts.owner as string,
@@ -522,16 +520,16 @@ export class AutoUpdater {
                   ghCore.error(
                     `Merge conflict label '${mergeConflictLabel}' does not exist on the remote. Skipping label application.`,
                   );
-                  labelExists = false;
+                  throw err;
                 } else {
                   ghCore.error(
                     `Error checking for label '${mergeConflictLabel}': ${err}`,
                   );
-                  labelExists = false;
+                  throw err;
                 }
               }
 
-              if (labelExists && !currentLabels.includes(mergeConflictLabel)) {
+              if (!currentLabels.includes(mergeConflictLabel)) {
                 const newLabels = [...currentLabels, mergeConflictLabel];
                 await this.octokit.rest.issues.update({
                   owner: mergeOpts.owner as string,
@@ -542,10 +540,6 @@ export class AutoUpdater {
                 ghCore.info(
                   `Added merge conflict label '${mergeConflictLabel}' to PR #${prNumber}.`,
                 );
-              } else if (!labelExists) {
-                ghCore.info(
-                  `Did not add label '${mergeConflictLabel}' because it does not exist on the remote.`,
-                );
               } else {
                 ghCore.info(
                   `Merge conflict label '${mergeConflictLabel}' already present on PR #${prNumber}.`,