Improve config value splitting for comma separated sets (#556)

Signed-off-by: Matt Norton <matt@carrotmanmatt.com>

Author: CarrotManMatt

cogs/invite_link.py

@@ -22,7 +22,7 @@ class InviteLinkCommandCog(TeXBotBaseCog):
         name="invite-link", description="Display the invite link to this server."
     )
     async def invite_link(self, ctx: "TeXBotApplicationContext") -> None:  # type: ignore[misc]
-        """Definition & callback response of the "invite-link" command."""
+        """Definition & callback response of the "invite_link" command."""
         discord_invite_url: str | None = settings["CUSTOM_DISCORD_INVITE_URL"]
 
         if not discord_invite_url:

config.py

@@ -743,15 +743,15 @@ def _setup_statistics_days(cls) -> None:
     def _setup_statistics_roles(cls) -> None:
         raw_statistics_roles: str = os.getenv("STATISTICS_ROLES", default="").strip()
 
-        statistics_roles: AbstractSet[str] = (
-            {
-                raw_statistics_role.strip()
-                for raw_statistics_role in raw_statistics_roles.split(",")
-                if raw_statistics_role
-            }
-            if raw_statistics_roles
-            else DEFAULT_STATISTICS_ROLES
-        )
+        if not raw_statistics_roles:
+            cls._settings["STATISTICS_ROLES"] = DEFAULT_STATISTICS_ROLES
+            return
+
+        statistics_roles: AbstractSet[str] = {
+            raw_statistics_role.strip()
+            for raw_statistics_role in raw_statistics_roles.split(",")
+            if raw_statistics_role.strip()
+        }
 
         cls._settings["STATISTICS_ROLES"] = (
             statistics_roles if statistics_roles else DEFAULT_STATISTICS_ROLES