[dist] Drop redundant portable suffix from portable dist

Author: Breakthrough

RELEASE-PLAN.md

@@ -45,7 +45,7 @@ Optional: version referenced below as `X.Y[.Z]` - replace with the real version
 - [ ] Tag `vX.Y[.Z]-release` on that commit and push. Wait for all tests/builds to pass.
 - [ ] Approve code signing request on SignPath, download `scenedetect-signed.zip`
 - [ ] Finalize Windows artifacts locally (CI can't do this - signing happens after the AppVeyor build, so the signed-exe swap and hashing must run locally):
-  - Create `dist/signed/` and copy in both `scenedetect-signed.zip` (from SignPath) and `PySceneDetect-X.Y.Z-portable.zip` (from the AppVeyor `PySceneDetect-win64_portable` artifact).
+  - Create `dist/signed/` and copy in both `scenedetect-signed.zip` (from SignPath) and `PySceneDetect-X.Y.Z.zip` (from the AppVeyor `PySceneDetect-win64` artifact).
   - Run `python scripts/finalize_windows_dist.py`. This swaps the signed `scenedetect.exe` into the portable `.zip`, repacks it with 7-Zip, copies out the signed `.msi`, and writes `PySceneDetect-X.Y.Z.manifest.json` + `SHA256SUMS`.
 - [ ] Draft release on Github using the tagged commit: include full changelog & release notes, signed portable .ZIP, signed .MSI installer, Python .whl/.tar.gz packages, and checksum manifests (`PySceneDetect-X.Y.Z.manifest.json` + `SHA256SUMS`)
 - [ ] Verify all artifacts uploaded to Github release are valid and named correctly

appveyor.yml

@@ -133,14 +133,14 @@ test_script:
   - scenedetect.exe -i ../../tests/resources/testvideo.mp4 -b pyav detect-content time -e 2s
 
 artifacts:
-  # Portable ZIP (named PySceneDetect-X.Y.Z-portable.zip by stage_windows_dist.py)
-  - path: dist/PySceneDetect-*-portable.zip
-    name: PySceneDetect-win64_portable
+  # Portable ZIP (named PySceneDetect-X.Y.Z.zip by stage_windows_dist.py)
+  - path: dist/PySceneDetect-*.zip
+    name: PySceneDetect-win64
   # MSI Installer + .EXE Bundle for Signing
   - path: dist/scenedetect-signed.zip
     name: PySceneDetect-win64_installer
   # Build provenance: post-sync .aip and the portable payload manifest.
   - path: dist/PySceneDetect.aip
     name: PySceneDetect-build-manifest-aip
-  - path: dist/PySceneDetect-*-portable.manifest.txt
+  - path: dist/PySceneDetect-*.manifest.txt
     name: PySceneDetect-build-manifest-payload

scripts/finalize_windows_dist.py

@@ -21,10 +21,10 @@
 
 Expected inputs (in --staging-dir, default `dist/signed/`):
     scenedetect-signed.zip              - SignPath bundle (signed .exe + .msi)
-    PySceneDetect-X.Y.Z-portable.zip    - portable .zip from AppVeyor
+    PySceneDetect-X.Y.Z.zip             - portable .zip from AppVeyor
 
 Outputs (written to the same directory):
-    PySceneDetect-X.Y.Z-portable.zip    - repacked with the signed .exe
+    PySceneDetect-X.Y.Z.zip    - repacked with the signed .exe
     PySceneDetect-X.Y.Z-win64.msi       - signed MSI extracted from the bundle
     PySceneDetect-X.Y.Z.manifest.json   - structured per-file SHA256 manifest
     SHA256SUMS                          - flat sha256sum -c compatible output
@@ -127,8 +127,7 @@ def verify_authenticode(path: Path) -> None:
     lines = [line.strip() for line in result.stdout.splitlines() if line.strip()]
     if result.returncode != 0 or not lines:
         sys.exit(
-            f"Authenticode check for {path.name} failed to run.\n"
-            f"  stderr: {result.stderr.strip()}"
+            f"Authenticode check for {path.name} failed to run.\n  stderr: {result.stderr.strip()}"
         )
     status = lines[0]
     subject = lines[1] if len(lines) > 1 else "<no certificate>"
@@ -247,7 +246,7 @@ def main() -> None:
         "--staging-dir",
         type=Path,
         default=REPO_DIR / "dist" / "signed",
-        help="Directory holding scenedetect-signed.zip and PySceneDetect-*-portable.zip.",
+        help="Directory holding scenedetect-signed.zip and PySceneDetect-*.zip.",
     )
     args = parser.parse_args()
 
@@ -256,7 +255,7 @@ def main() -> None:
         sys.exit(f"{staging} not found")
 
     signed_bundle = staging / "scenedetect-signed.zip"
-    portable_zip = staging / f"PySceneDetect-{VERSION}-portable.zip"
+    portable_zip = staging / f"PySceneDetect-{VERSION}.zip"
     if not signed_bundle.is_file():
         sys.exit(f"{signed_bundle} not found")
     if not portable_zip.is_file():

scripts/stage_windows_dist.py

@@ -153,8 +153,8 @@ def stage_thirdparty_licenses() -> None:
 
 
 def make_portable_zip(version: str) -> None:
-    zip_path = DIST_DIR / f"PySceneDetect-{version}-portable.zip"
-    manifest_path = DIST_DIR / f"PySceneDetect-{version}-portable.manifest.txt"
+    zip_path = DIST_DIR / f"PySceneDetect-{version}.zip"
+    manifest_path = DIST_DIR / f"PySceneDetect-{version}.manifest.txt"
     if zip_path.exists():
         zip_path.unlink()
     print(f"Creating {zip_path.relative_to(REPO_DIR)}...")