[tests] Expand unit and release tests for 0.7 release

Breakthrough · Breakthrough · commit 82a895f9cf49 · 2026-05-02T18:33:25.000-04:00
diff --git a/tests/release/test_backends.py b/tests/release/test_backends.py
@@ -19,7 +19,7 @@
 
 import pytest
 
-from scenedetect import ContentDetector, SceneManager, open_video
+from scenedetect import ContentDetector, SceneManager, ThresholdDetector, open_video
 
 REPO_ROOT = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
@@ -88,3 +88,41 @@ def test_cross_backend_consistency(rel_path, is_vfr):
             assert actual == expected, (
                 f"CFR frame-number mismatch between {backend} and {reference}"
             )
+
+
+@pytest.mark.release
+def test_cross_backend_threshold_determinism():
+    """detect-threshold cut frames must be backend-deterministic across PyAV/OpenCV/MoviePy.
+
+    Regression coverage for the changelog item: previously the cut could differ by 1 frame
+    between PyAV and OpenCV when the fade midpoint landed on a `.5` rounding boundary
+    (PyAV uses sub-microsecond PTS; OpenCV uses millisecond-truncated CAP_PROP_POS_MSEC).
+    """
+    video_path = os.path.join(REPO_ROOT, "tests/resources/fades.mp4")
+    if not os.path.exists(video_path):
+        pytest.skip("tests/resources/fades.mp4 not present.")
+
+    backends = _installed_backends()
+    if len(backends) < 2:
+        pytest.skip(f"Need at least two backends, have: {backends}")
+
+    results = {}
+    for backend in backends:
+        try:
+            video = open_video(video_path, backend=backend)
+        except Exception as exc:
+            pytest.skip(f"{backend} failed to open fades.mp4: {exc}")
+        sm = SceneManager()
+        sm.add_detector(ThresholdDetector())
+        sm.detect_scenes(video)
+        # `frame_num` of the first frame of each cut, excluding the implicit 0th cut.
+        results[backend] = [s[0].frame_num for s in sm.get_scene_list()[1:]]
+
+    reference = backends[0]
+    expected = results[reference]
+    for backend in backends[1:]:
+        actual = results[backend]
+        assert actual == expected, (
+            f"detect-threshold cut frames differ between {backend}={actual} and "
+            f"{reference}={expected} - the .5-boundary rounding fix has regressed."
+        )
diff --git a/tests/release/test_cli_permutations.py b/tests/release/test_cli_permutations.py
@@ -140,3 +140,125 @@ def test_cli_min_scene_len_smoke(test_video_file, tmp_path):
         cwd=os.path.abspath(os.path.dirname(test_video_file) + "/../.."),
     )
     assert result.returncode == 0, f"stderr:\n{result.stderr}\nstdout:\n{result.stdout}"
+
+
+@pytest.mark.release
+def test_cli_save_fcp_smoke(test_video_file, tmp_path):
+    """save-fcp writes a well-formed Final Cut Pro XML."""
+    import xml.etree.ElementTree as ET
+
+    result = _run(
+        [
+            "-i",
+            os.path.abspath(test_video_file),
+            "-o",
+            str(tmp_path),
+            "detect-content",
+            "save-fcp",
+        ],
+        cwd=os.path.abspath(os.path.dirname(test_video_file) + "/../.."),
+    )
+    assert result.returncode == 0, f"stderr:\n{result.stderr}\nstdout:\n{result.stdout}"
+    xml_files = [p for p in tmp_path.iterdir() if p.suffix == ".xml"]
+    assert xml_files, "save-fcp produced no .xml file"
+    # Parse must succeed; root <fcpxml> or <xmeml> depending on the FCP variant.
+    root = ET.parse(xml_files[0]).getroot()
+    assert root.tag in ("fcpxml", "xmeml"), f"Unexpected root element: {root.tag}"
+
+
+@pytest.mark.release
+def test_cli_save_qp_smoke(test_video_file, tmp_path):
+    """save-qp writes a QP file with `<frame> I <shift>` lines for scene boundaries."""
+    result = _run(
+        [
+            "-i",
+            os.path.abspath(test_video_file),
+            "-o",
+            str(tmp_path),
+            "detect-content",
+            "save-qp",
+        ],
+        cwd=os.path.abspath(os.path.dirname(test_video_file) + "/../.."),
+    )
+    assert result.returncode == 0, f"stderr:\n{result.stderr}\nstdout:\n{result.stdout}"
+    qp_files = [p for p in tmp_path.iterdir() if p.suffix == ".qp"]
+    assert qp_files, "save-qp produced no .qp file"
+    contents = qp_files[0].read_text().strip()
+    assert contents, "save-qp produced an empty file"
+    # Each line must be `<frame_number> I <shift>` where shift is an integer.
+    for line in contents.splitlines():
+        parts = line.split()
+        assert len(parts) == 3 and parts[0].isdigit() and parts[1] == "I", (
+            f"Malformed QP line: {line!r}"
+        )
+        int(parts[2])  # shift must parse as int (may be negative)
+
+
+@pytest.mark.release
+def test_cli_save_html_smoke(test_video_file, tmp_path):
+    """save-html replaces the deprecated export-html and produces an HTML report.
+
+    Note: save-html lacks its own --output option and ignores the global -o, so the
+    file is routed via --filename with an absolute path.
+    """
+    out_html = tmp_path / "scenes.html"
+    result = _run(
+        [
+            "-i",
+            os.path.abspath(test_video_file),
+            "detect-content",
+            "save-html",
+            "--filename",
+            str(out_html),
+            "--no-images",
+        ],
+        cwd=os.path.abspath(os.path.dirname(test_video_file) + "/../.."),
+    )
+    assert result.returncode == 0, f"stderr:\n{result.stderr}\nstdout:\n{result.stdout}"
+    assert out_html.exists(), f"save-html produced no file at {out_html}"
+    contents = out_html.read_text(encoding="utf-8")
+    # The output is an HTML fragment (a <table> of scenes), not a full document.
+    lowered = contents.lower()
+    assert "<table" in lowered and "</table>" in lowered, (
+        f"save-html output is missing the scenes <table>:\n{contents[:500]}"
+    )
+
+
+@pytest.mark.release
+def test_cli_save_edl_start_timecode_smoke(test_video_file, tmp_path):
+    """save-edl --start-timecode produces an EDL where event timestamps are offset by the
+    requested start. Both SMPTE (HH:MM:SS:FF) and 8-digit (HHMMSSFF) inputs must be accepted."""
+    repo_cwd = os.path.abspath(os.path.dirname(test_video_file) + "/../..")
+
+    def _edl(form: str, out_dir):
+        result = _run(
+            [
+                "-i",
+                os.path.abspath(test_video_file),
+                "-o",
+                str(out_dir),
+                "detect-content",
+                "save-edl",
+                "--start-timecode",
+                form,
+            ],
+            cwd=repo_cwd,
+        )
+        assert result.returncode == 0, (
+            f"start-timecode {form!r} failed:\nstderr:\n{result.stderr}\nstdout:\n{result.stdout}"
+        )
+        edls = [p for p in out_dir.iterdir() if p.suffix == ".edl"]
+        assert edls, f"save-edl --start-timecode {form!r} produced no .edl file"
+        return edls[0].read_text()
+
+    # SMPTE form.
+    smpte_dir = tmp_path / "smpte"
+    smpte_dir.mkdir()
+    smpte_text = _edl("01:00:00:00", smpte_dir)
+    # 8-digit form (semantically equivalent to 01:00:00:00).
+    digit_dir = tmp_path / "digit"
+    digit_dir.mkdir()
+    digit_text = _edl("01000000", digit_dir)
+    # Both EDLs must contain at least one event line with the 01:00:... offset visible.
+    assert "01:00:" in smpte_text, f"SMPTE start TC not propagated to EDL:\n{smpte_text}"
+    assert "01:00:" in digit_text, f"8-digit start TC not propagated to EDL:\n{digit_text}"
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -367,6 +367,47 @@ def test_cli_framerate_legacy_alias():
     assert exit_code == 0
 
 
+def test_cli_min_scene_len_accepts_all_timecode_forms(tmp_path: Path):
+    """`--min-scene-len` (and equivalent options) must accept frames, seconds, and timecodes
+    in v0.7 per the changelog. The four forms below all resolve to ~20 frames at 23.976 fps
+    and must produce byte-identical scene lists."""
+    # 20 frames @ 23.976 fps = 0.8341... s, which rounds to the same nearest frame regardless
+    # of which form is parsed.
+    forms = ["20", "0.834", "0.834s", "00:00:00.834"]
+    outputs = []
+    for form in forms:
+        out = tmp_path / f"scenes_{form.replace(':', '_')}.csv"
+        exit_code, _ = invoke_cli(
+            [
+                "-i",
+                DEFAULT_VIDEO_PATH,
+                "-o",
+                str(tmp_path),
+                "time",
+                "-s",
+                "2s",
+                "-d",
+                "4s",
+                "detect-content",
+                "--min-scene-len",
+                form,
+                "list-scenes",
+                "-f",
+                out.name,
+                "-q",  # suppress stdout printing
+            ],
+        )
+        assert exit_code == 0, f"--min-scene-len {form!r} rejected"
+        assert out.exists(), f"--min-scene-len {form!r} did not produce {out}"
+        outputs.append((form, out.read_text()))
+    # All forms must produce the same scene list.
+    base_form, base_csv = outputs[0]
+    for form, csv in outputs[1:]:
+        assert csv == base_csv, (
+            f"Scene list differs between --min-scene-len {base_form!r} and {form!r}"
+        )
+
+
 def test_cli_list_scenes(tmp_path: Path):
     """Test `list-scenes` command."""
     exit_code, _ = invoke_cli(
@@ -624,10 +665,29 @@ def test_cli_save_html(tmp_path: Path):
         invoke_scenedetect(base_command, COMMAND="save-html --no-images", output_dir=tmp_path) == 0
     )
     # Ensure we can still call the now deprecated export-html command.
-    assert invoke_scenedetect(base_command, COMMAND="save-html", output_dir=tmp_path) == 0
+    assert invoke_scenedetect(base_command, COMMAND="export-html", output_dir=tmp_path) == 0
     # TODO: Check for existence of HTML & image files.
 
 
+def test_cli_legacy_v06_config_file(tmp_path: Path):
+    """A v0.6-era scenedetect.cfg using the deprecated `[export-html]` section must still load
+    in v0.7. The parser maps `[export-html]` -> `[save-html]` (via DEPRECATED_COMMANDS in
+    scenedetect/_cli/config.py) and emits a deprecation warning on load. This is the most
+    likely silent break for users upgrading config files; the option set under both sections
+    is identical."""
+    legacy_cfg = tmp_path / "scenedetect.cfg"
+    legacy_cfg.write_text(
+        # Mix of unchanged sections and the renamed `[export-html]` section.
+        "[global]\nmin-scene-len = 0.6s\n\n"
+        "[detect-content]\nthreshold = 27\n\n"
+        "[export-html]\nfilename = $VIDEO_NAME-Scenes.html\nno-images = yes\n"
+    )
+    exit_code, output = invoke_cli(
+        ["-c", str(legacy_cfg), "-i", DEFAULT_VIDEO_PATH, "time", "-s", "2s", "-d", "1s"],
+    )
+    assert exit_code == 0, f"v0.6-style config rejected:\n{output}"
+
+
 def test_cli_save_qp(tmp_path: Path):
     """Test `save-qp` command with and without a custom filename format."""
     EXPECTED_QP_CONTENTS = """
diff --git a/tests/test_timecode.py b/tests/test_timecode.py
@@ -98,6 +98,15 @@ def test_frame_rate_for_vfr():
     assert tc.time_base != 1 / tc.frame_rate
 
 
+def test_frame_num_and_frame_rate_are_read_only():
+    """Per migration guide, `frame_num`, `frame_rate`, and the legacy `framerate` alias are
+    read-only properties; callers must construct a new FrameTimecode to change them."""
+    tc = FrameTimecode(timecode=0, fps=30.0)
+    for attr in ("frame_num", "frame_rate", "framerate"):
+        with pytest.raises(AttributeError):
+            setattr(tc, attr, 99)
+
+
 def test_equal_frame_rate_legacy_alias():
     """`equal_framerate()` is the soft-deprecated alias for `equal_frame_rate()` (issue #548).
     Both forms should produce identical results for every accepted operand type."""
